[typescript-angular] add providedIn support #8183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topce
changed the title
|
Good stuff
…On Fri, May 18, 2018, 8:38 AM topce ***@***.***> wrote:
@@### PR checklist
- Read the contribution guidelines
<https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md>
.
- Ran the shell script under ./bin/ to update Petstore sample so that
CIs can verify the change. (For instance, only need to run
./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if
updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG}
client's mustache templates). Windows batch files can be found in
.\bin\windows\.
- Filed the PR against the correct branch: 3.0.0 branch for changes
related to OpenAPI spec 3.0. Default: master.
- Copied the technical committee
<https://github.com/swagger-api/swagger-codegen/#swagger-codegen-technical-committee>
to review the pull request if your PR is targeting a particular programming
language.
Description of the PR
add support for Tree Shakable Providers as described in the blog
angular blog
<https://blog.angular.io/version-6-of-angular-now-available-cc56b0efa7a4>
add more people to review
@sebastianhaas <https://github.com/sebastianhaas> @TiFu
<https://github.com/TiFu> @taxpon <https://github.com/taxpon> @kenisteward
<https://github.com/kenisteward> @Vrolijkx <https://github.com/Vrolijkx>
@roni-frantchi <https://github.com/roni-frantchi>
@wing328 <https://github.com/wing328>
------------------------------
You can view, comment on, or merge this pull request online at:
#8183
Commit Summary
- add provideedIn support
File Changes
- *M*
modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/TypeScriptAngularClientCodegen.java
<https://github.com/swagger-api/swagger-codegen/pull/8183/files#diff-0>
(8)
- *M*
modules/swagger-codegen/src/main/resources/typescript-angular/api.service.mustache
<https://github.com/swagger-api/swagger-codegen/pull/8183/files#diff-1>
(7)
Patch Links:
- https://github.com/swagger-api/swagger-codegen/pull/8183.patch
- https://github.com/swagger-api/swagger-codegen/pull/8183.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8183>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AMPLtceruvUeWLNtqgNqMGYFRbVosRJWks5tzsC3gaJpZM4T8wi5>
.
|
|
maybe to merge this ;-) |
|
it look nobody maintain this project so I will close this |
|
yes, we are still maintaining this project, sorry for delay i had not seen this one. |
|
LG, thanks @topce |
|
@HugoMario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@@### PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
add support for Tree Shakable Providers as described in the blog
angular blog
add more people to review
@sebastianhaas @TiFu @taxpon @kenisteward @Vrolijkx @roni-frantchi
@wing328