-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ssv and tsv formats. Added csv. #7974
base: master
Are you sure you want to change the base?
Conversation
Fixed query array parameters for collection formats ssv and tsv. Added csv format
cc the technical committee: @ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille |
@borisbn Can you run |
@MartinDelille Sorry, but I'm very new to |
@borisbn yes, after updating the files, you will need to add a new commit (git commit -a) and push out the new commit to your batch "patch-1" (git push origin patch-1) so this PR will contain 2 commits (or more) (if there are new files, you will need to include the new files with "git add -A") |
You may not be able to push to origin since you don't have write access to https://github.com/swagger-api/swagger-codegen Let me tell you how I manage to make pull request: First I clone the original code:
Then I switch branch:
I perform my edit and commit it to this new branch. I fork the github repo (clicking the fork button here: https://github.com/swagger-api/swagger-codegen). I need to add a new remote to my local repository:
Note that To check that your remote are well set-up, you can type:
Now I push my commit to my Github repository:
Note that Now if you go back to https://github.com/swagger-api/swagger-codegen, I can see a button proposing to create a pull request. In your case, you already have fork the repository (since we can see it here: https://github.com/borisbn/swagger-codegen) so you just need to do the following: Add the remote to your local repository:
Pull your branch:
Checkout your branch:
Do your edit:
Commit it:
Push it:
After that your change should appear in this PR. I hope I'm clear! Don't hesitate to ask if necessary! |
Fixed query array parameters for collection formats ssv and tsv. Added csv format
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)