Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Improve duplicated validation logic #7954

Merged

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Apr 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Current Model has the duplicated validation logic between listInvalidProperties() and valid().
This PR improves that: valid() calls listInvalidProperties(), and use the result which listInvalidProperties() returns.

@ackintosh
Copy link
Contributor Author

@wing328 wing328 added this to the v2.4.0 milestone Apr 6, 2018
@wing328 wing328 merged commit f9ae84d into swagger-api:master Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants