[kotlin] Add json annotation to each enum value. #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejithon
changed the title
|
cc @jimschubert for review. |
jimschubert
approved these changes
Mar 30, 2018
| @@ -1,3 +1,5 @@ | |||
| {{#hasEnums}}import com.squareup.moshi.Json{{/hasEnums}} | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this extra newline?
Also, I think the newline generated by the hasEnums check when that is false can be eliminated by putting the opening and closing tags on their own lines.
There was a problem hiding this comment.
@jimschubert Thank you for reviewing, I will remove it soon.
|
@jimschubert Does my updating make sense? |
|
@ejithon definitely! Thanks. |
jimschubert
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
#7811
Add moshi.Json annotation to each enum value.