Skip to content

[Docker] Fixing build failure (#7870) #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Docker] Fixing build failure (#7870) #7871

wants to merge 1 commit into from

Conversation

loginakhil
Copy link

@loginakhil loginakhil commented Mar 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Docker builds without any errors now

@wing328
Copy link
Contributor

wing328 commented Mar 19, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added the Docker label Mar 19, 2018
@wing328 wing328 added this to the v2.4.0 milestone Mar 19, 2018
 * Copying swagger-generator in Dockerfile to fix docker build failures (#7870)
@loginakhil
Copy link
Author

loginakhil commented Mar 19, 2018

@wing328 Thanks for the update, i have modified the commit to tag my username correctly, please verify.

@loginakhil loginakhil closed this Mar 19, 2018
@loginakhil loginakhil reopened this Mar 19, 2018
@whoan
Copy link
Contributor

whoan commented Aug 30, 2018

I would love to see this merged. Thanks @loginakhil .

@Blackclaws Blackclaws mentioned this pull request Dec 10, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants