[C++][qt] Fix warning message #7815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, good increments to improve the qtcpp generator. |
|
@etherealjoy Not yet but I'm planning too. Unfortunately I have a blocking issue there: #7802 |
stkrwork
suggested changes
Mar 11, 2018
| @@ -38,13 +38,13 @@ public: | |||
|
|
|||
| void cleanup(); | |||
|
|
|||
| String asJson (); | |||
| String asJson () override; | |||
There was a problem hiding this comment.
I dont think this file is actually needed, it doesnt use anything from QT and has a tizen namespace defined. Can you try generating a qt client without this mustache file? (Also remove it from the java file, if necessary)
There was a problem hiding this comment.
Yes indeed. I just removed it.
stkrwork
approved these changes
Mar 11, 2018
|
@MartinDelille thanks for the PR, which has been merged into master. Thanks @etherealjoy @stkrwork for reviewing the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
There is currently a warning when compiling Qt models:
These PR fix it.
Ping @ravinikam @stkrwork @fvarose