Improve JMeter Template : Fix Issue 7773 #7774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CSV DataSet ignore first line as it contains headers Share CSV for Thread-Group instead of doing it across all threads Use scheduler Add variables definable through properties for: - Rampup - Duration - Threads Drop HttpClient 3.1 customization Remove in Test Plan Element host and port as they are defined in User Variables
|
Please also update sample project under /samples/client/petstore/jmeter. |
|
Hello @davidkiss , Thanks for review. |
This comment swagger-api#7773 As per request update samples
davidkiss
approved these changes
Mar 14, 2018
|
Thanks. Looks good |
|
Thanks for review. Thanks |
|
Not sure. I don't have permission to do that. |
|
@pmouawad sorry for the delay. Just merged it. Thanks @davidkiss for reviewing the change. |
|
Thanks for your time ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @davidkiss,
PR checklist
3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
In CSV DataSet ignore first line as it contains headers
Share CSV for Thread-Group instead of doing it across all threads
Use scheduler
Add variables definable through properties for:
Drop HttpClient 3.1 customization
Remove in Test Plan Element host and port as they are defined in User Variables
This fixes:
#7773