Check date value before calling to_iso8601 #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deserializing a date value the value has to be a string when calling to_iso8601. Otherwise it fails with a match error due to a is_binary() guard.
|
@garte thanks for the PR. cc @niku @chingor13 for review. |
chingor13
suggested changes
Mar 9, 2018
| value = Map.get(model, field) | ||
| case is_binary(value) do | ||
| true -> case DateTime.from_iso8601(value) do | ||
| {:ok, datetime} -> |
There was a problem hiding this comment.
Another bug is that DateTime.from_iso8601 returns a tuple of size 3.
So it should actually be {:ok, datetime, _offset}
There was a problem hiding this comment.
Latest commit should fix this, would that be ok?
|
@garte thanks for the PR, which has been merged into master. @chingor13 thanks for reviewing the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing a date value the value has to be a string when calling to_iso8601. Otherwise it fails with a match error due to a is_binary() guard.