Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elm] Add support for array schemas #7729

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Conversation

lundal
Copy link
Contributor

@lundal lundal commented Feb 25, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The following swagger.yaml currently produces models with invalid types and encoder and decoder functions. This change generates valid code by using arrayModelType, instantiationTypes, Decode.list and Encode.list.

swagger: '2.0'
info:
  title: API
  version: "1.0.0"
host: localhost
consumes:
  - application/json
produces:
  - application/json
paths:
  /test:
    get:
      summary: test
      responses:
        200:
          description: StringArray
          schema:
            $ref: '#/definitions/StringArray'
    put:
      summary: test
      responses:
        200:
          description: ObjectArray
          schema:
            $ref: '#/definitions/ObjectArray'
definitions:
  StringArray:
    type: array
    items:
      type: string
  ObjectArray:
    type: array
    items:
      $ref: '#/definitions/Object'
  Object:
    type: object
    properties:
      id:
        type: string

The following schema definitions kinds are now supported:

MyStringArray:
  type: array
  items:
    type: string

MyObjectArray:
  type: array
  items:
    type: MyObject
@wing328
Copy link
Contributor

wing328 commented Feb 26, 2018

@lundal thanks for the PR.

cc @trenneman to review.

@eriktim
Copy link
Contributor

eriktim commented Feb 27, 2018

Looking great, thanks @lundal !

@wing328 wing328 merged commit 769a65c into swagger-api:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants