Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Non required enum property #7723

Merged
merged 7 commits into from
Mar 8, 2018
Merged

[PHP] Non required enum property #7723

merged 7 commits into from
Mar 8, 2018

Commits on Feb 25, 2018

  1. Add required enum property

    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    33640af View commit details
    Browse the repository at this point in the history

  2. Update samples

    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    7ffa93c View commit details
    Browse the repository at this point in the history

  3. Add test case which reproduce the problem 

    refs swagger-api#7686 (comment)
> 2. Non-required enum property is listed as invalid when omitted
    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    e70e115 View commit details
    Browse the repository at this point in the history

  4. If the property is not empty, perform validation

    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    377247f View commit details
    Browse the repository at this point in the history

  5. Update samples

    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    d0f098d View commit details
    Browse the repository at this point in the history

  6. Use is_null() according to setter implementation 

    refs https://github.com/ackintosh/swagger-codegen/blob/377247f125988b591685e9f7cedc95fe5e99bcc2/modules/swagger-codegen/src/main/resources/php/model_generic.mustache#L347
    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    66a6ee9 View commit details
    Browse the repository at this point in the history

  7. Update samples

    @ackintosh
    ackintosh committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    4fc810d View commit details
    Browse the repository at this point in the history