Feature/javaPlayWithAsynchronousControllers #7705

ignaciomolina · 2018-02-21T16:18:46Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @tzimisce012

Description of the PR

Add property to enable the use of asynchronous classes in java
Add support for asynchronous controllers with play framework and java8 CompletionStage interface

…ollers

JFCote

Please see my comments. Did you make sure to generate all the other samples for Play Framework? Since we don't see any change here, it's difficult to say if it's because there is no changes or if you forgot to run them.

Anyway, thanks for this very nice PR!

JFCote · 2018-02-21T17:44:50Z

samples/server/petstore/java-play-framework-async/app/controllers/PetApiController.java

+            throw new IllegalArgumentException("'body' parameter is required");
+        }
+
+        // controllerOnly  false


Why is this there?

Good catch, I miss to regenerate samples after removing that testing comments 😅

JFCote · 2018-02-21T17:44:57Z

samples/server/petstore/java-play-framework-async/app/controllers/PetApiController.java

+            apiKey = null;
+        }
+
+        // controllerOnly  false


same question

JFCote · 2018-02-21T17:45:06Z

samples/server/petstore/java-play-framework-async/app/controllers/PetApiController.java

+            }
+        }
+
+        // controllerOnly  false


same question

JFCote · 2018-02-21T17:45:15Z

samples/server/petstore/java-play-framework-async/app/controllers/PetApiController.java

+            }
+        }
+
+        // controllerOnly  false


ignaciomolina · 2018-02-22T09:24:44Z

Sorry, I had forgotten to regenerate the samples for the other play framework scenarios, It's done now

JFCote

Please make sure your changes don't modify the current samples since it should be 100% independent.

JFCote · 2018-02-22T13:07:02Z

...es/server/petstore/java-play-framework-controller-only/app/controllers/PetApiController.java

@@ -17,6 +17,7 @@
 import swagger.SwaggerUtils;
 import com.fasterxml.jackson.core.type.TypeReference;

+


There is a lot of new unnecessary blank line. Can you change the mustache to prevent that?

In the best case scenario, your changes would not create anything new in the old samples

JFCote · 2018-02-22T13:08:26Z

...er/petstore/java-play-framework-fake-endpoints/app/controllers/AnotherFakeApiController.java

        Client obj = imp.testSpecialTags(body);
        if (configuration.getBoolean("useOutputBeanValidation")) {
            SwaggerUtils.validate(obj);
        }
-        JsonNode result = mapper.valueToTree(obj);
-        return ok(result);
+            JsonNode result = mapper.valueToTree(obj);


here the tabulation is not good anymore

JFCote · 2018-02-22T13:08:43Z

...petstore/java-play-framework-fake-endpoints/app/controllers/AnotherFakeApiControllerImp.java

@@ -13,7 +13,7 @@
    @Override
    public Client testSpecialTags(Client body) throws Exception {
        //Do your magic!!!
-        return new Client();
+
+            return new Client();


tabulation not good anymore

JFCote · 2018-02-22T13:09:04Z

...java-play-framework-fake-endpoints/app/controllers/AnotherFakeApiControllerImpInterface.java

@@ -11,6 +11,6 @@

 @SuppressWarnings("RedundantThrows")
 public interface AnotherFakeApiControllerImpInterface {
-    Client testSpecialTags(Client body) throws Exception;
+   Client testSpecialTags(Client body) throws Exception;


missing a space

JFCote · 2018-02-22T13:09:13Z

...es/server/petstore/java-play-framework-fake-endpoints/app/controllers/FakeApiController.java

        Boolean obj = imp.fakeOuterBooleanSerialize(body);
-        JsonNode result = mapper.valueToTree(obj);
-        return ok(result);
+            JsonNode result = mapper.valueToTree(obj);


bad tabulation

JFCote · 2018-02-22T13:10:57Z

...es/server/petstore/java-play-framework-fake-endpoints/app/controllers/FakeApiController.java

        OuterComposite obj = imp.fakeOuterCompositeSerialize(body);
        if (configuration.getBoolean("useOutputBeanValidation")) {
            SwaggerUtils.validate(obj);
        }
-        JsonNode result = mapper.valueToTree(obj);
-        return ok(result);
+            JsonNode result = mapper.valueToTree(obj);


I could continue on and on but like I said earlier, just make sure there is no changes in the previous samples and I will approve this PR. If you have trouble using the mustache file (it can be tricky), let me know exactly where you are struggling and I will try to help.

there is an easy way to fix the tabulation issue without having to add each one of them manually? 😰

Well it is generated, so if you fix the mustache file, it will be fix everywhere. Never edit manually the files in the "sample" folder.

No, I meant in the mustache file

I think you only need to change it at one place. I don't have time right now to check it out but I'm sure you'll figure it out by trial and error :) If you are completely clueless, I could check it next week.

ok I fixed the other scenarios, but the async one still lacks tabulations 😕

JFCote · 2018-02-22T13:11:16Z

...tstore/java-play-framework-fake-endpoints/app/controllers/FakeApiControllerImpInterface.java

@@ -15,22 +15,22 @@

 @SuppressWarnings("RedundantThrows")
 public interface FakeApiControllerImpInterface {
-    Boolean fakeOuterBooleanSerialize(Boolean body) throws Exception;
+   Boolean fakeOuterBooleanSerialize(Boolean body) throws Exception;


all missing a space

JFCote · 2018-02-22T13:12:01Z

samples/server/petstore/java-play-framework-fake-endpoints/public/swagger.json

@@ -749,8 +749,8 @@
          "type" : "array",
          "items" : {
            "type" : "string",
-            "default" : "$",
-            "enum" : [ ">", "$" ]
+            "enum" : [ ">", "$" ],


theses changes could be ignored, they are caused by the core that doesn't do some sorting and because of this, the order is totally random.

JFCote · 2018-02-23T13:04:03Z

@ignaciomolina Nice job. I will take some time next week to help you fix the problem with the tabulation in the async sample. But for the rest, this look promising!

JFCote · 2018-03-01T13:01:47Z

@ignaciomolina Sorry about the delay, I'm very busy right now. Will try to check it somewhere today or tomorrow but can't be sure. Maybe beginning of next week. Sorry about that :)

JFCote · 2018-03-06T17:55:47Z

@ignaciomolina I'm checking this tomorrow morning! I didn't forget you! :)

JFCote · 2018-03-07T19:26:22Z

@ignaciomolina
Here is the solution, please copy and replace you code, try generating and let me know!

newApi.mustache

package {{package}};

{{#imports}}import {{import}};
{{/imports}}

import play.mvc.Http;
import java.util.List;
import java.util.ArrayList;
import java.util.HashMap;
import java.io.FileInputStream;
{{#useBeanValidation}}
import javax.validation.constraints.*;
{{/useBeanValidation}}
{{>generatedAnnotation}}
{{#operations}}
public class {{classname}}ControllerImp {{#useInterfaces}}implements {{classname}}ControllerImpInterface{{/useInterfaces}} {
{{#operation}}
    {{#useInterfaces}}@Override{{/useInterfaces}}
    public {{^returnType}}void{{/returnType}}{{#returnType}}{{#supportAsync}}CompletionStage<{{/supportAsync}}{{>returnTypesNoVoid}}{{#supportAsync}}>{{/supportAsync}}{{/returnType}} {{operationId}}({{#allParams}}{{>pathParams}}{{>queryParams}}{{>bodyParams}}{{>formParams}}{{>headerParams}}{{#hasMore}}, {{/hasMore}}{{/allParams}}) {{#handleExceptions}}throws Exception{{/handleExceptions}} {
        //Do your magic!!!
        {{#returnType}}
        {{#supportAsync}}
        return CompletableFuture.supplyAsync(() -> {
        {{/supportAsync}}
        {{#isResponseFile}}
        return new FileInputStream("replace this");
        {{/isResponseFile}}
        {{^isResponseFile}}
        {{#supportAsync}}   {{/supportAsync}}return new {{>returnTypesNoVoidNoAbstract}}({{#vendorExtensions.missingReturnInfoIfNeeded}}{{vendorExtensions.missingReturnInfoIfNeeded}}{{/vendorExtensions.missingReturnInfoIfNeeded}});
        {{/isResponseFile}}
        {{#supportAsync}}
        });
        {{/supportAsync}}
        {{/returnType}}
    }

{{/operation}}
}
{{/operations}}

newApiController.mustache

package {{package}};

{{#imports}}import {{import}};
{{/imports}}

import play.mvc.Controller;
import play.mvc.Result;
import play.mvc.Http;
import java.util.List;
import java.util.Map;
import java.util.ArrayList;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.JsonNode;
import com.google.inject.Inject;
import java.io.File;
{{^handleExceptions}}
import java.io.IOException;
{{/handleExceptions}}
import swagger.SwaggerUtils;
import com.fasterxml.jackson.core.type.TypeReference;
{{#supportAsync}}

import java.util.concurrent.CompletionStage;
import java.util.concurrent.CompletableFuture;
{{/supportAsync}}

{{#useBeanValidation}}
import javax.validation.constraints.*;
import play.Configuration;
{{/useBeanValidation}}

{{#wrapCalls}}
import swagger.SwaggerUtils.ApiAction;
{{/wrapCalls}}

{{>generatedAnnotation}}
{{#operations}}
public class {{classname}}Controller extends Controller {

    {{^controllerOnly}}
    private final {{classname}}ControllerImp{{#useInterfaces}}Interface{{/useInterfaces}} imp;
    {{/controllerOnly}}
    private final ObjectMapper mapper;
    {{#useBeanValidation}}
    private final Configuration configuration;
    {{/useBeanValidation}}

    @Inject
    private {{classname}}Controller({{#useBeanValidation}}Configuration configuration{{^controllerOnly}}, {{/controllerOnly}}{{/useBeanValidation}}{{^controllerOnly}}{{classname}}ControllerImp{{#useInterfaces}}Interface{{/useInterfaces}} imp{{/controllerOnly}}) {
        {{^controllerOnly}}
        this.imp = imp;
        {{/controllerOnly}}
        mapper = new ObjectMapper();
        {{#useBeanValidation}}
        this.configuration = configuration;
        {{/useBeanValidation}}
    }

{{#operation}}

    {{#wrapCalls}}@ApiAction{{/wrapCalls}}
    public {{#supportAsync}}CompletionStage<{{/supportAsync}}Result{{#supportAsync}}>{{/supportAsync}} {{operationId}}({{#pathParams}}{{>pathParams}}{{#hasMore}},{{/hasMore}}{{/pathParams}}) {{^handleExceptions}}{{#bodyParams}}throws IOException{{/bodyParams}}{{/handleExceptions}}{{#handleExceptions}}throws Exception{{/handleExceptions}} {
        {{#bodyParams}}
        {{^collectionFormat}}
        JsonNode node{{paramName}} = request().body().asJson();
        {{{dataType}}} {{paramName}};
        if (node{{paramName}} != null) {
            {{paramName}} = mapper.readValue(node{{paramName}}.toString(), {{#isContainer}}new TypeReference<{{{dataType}}}>(){}{{/isContainer}}{{^isContainer}}{{{dataType}}}.class{{/isContainer}});
            {{#useBeanValidation}}
            if (configuration.getBoolean("useInputBeanValidation")) {
                {{#isListContainer}}
                for ({{{baseType}}} curItem : {{paramName}}) {
                    SwaggerUtils.validate(curItem);
                }
                {{/isListContainer}}
                {{#isMapContainer}}
                for (Map.Entry<String, {{{baseType}}}> entry : {{paramName}}.entrySet()) {
                    SwaggerUtils.validate(entry.getValue());
                }
                {{/isMapContainer}}
                {{^isContainer}}
                SwaggerUtils.validate({{paramName}});
                {{/isContainer}}
            }
            {{/useBeanValidation}}
        } else {
            {{#required}}
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
            {{/required}}
            {{^required}}
            {{paramName}} = null;
            {{/required}}
        }
        {{/collectionFormat}}
        {{/bodyParams}}
        {{#queryParams}}
        {{#collectionFormat}}
        String[] {{paramName}}Array = request().queryString().get("{{baseName}}");
        {{#required}}
        if ({{paramName}}Array == null) {
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
        }
        {{/required}}
        List<String> {{paramName}}List = SwaggerUtils.parametersToList("{{collectionFormat}}", {{paramName}}Array);
        {{{dataType}}} {{paramName}} = new Array{{{dataType}}}();
        for (String curParam : {{paramName}}List) {
            if (!curParam.isEmpty()) {
                //noinspection UseBulkOperation
                {{paramName}}.add({{>itemConversionBegin}}curParam{{>itemConversionEnd}});
            }
        }
        {{/collectionFormat}}
        {{^collectionFormat}}
        String value{{paramName}} = request().getQueryString("{{baseName}}");
        {{{dataType}}} {{paramName}};
        if (value{{paramName}} != null) {
            {{paramName}} = {{>conversionBegin}}value{{paramName}}{{>conversionEnd}};
        } else {
            {{#required}}
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
            {{/required}}
            {{^required}}
            {{paramName}} = {{>paramDefaultValue}};
            {{/required}}
        }
        {{/collectionFormat}}
        {{/queryParams}}
        {{#formParams}}
        {{^notFile}}
        {{{dataType}}} {{paramName}} = request().body().asMultipartFormData().getFile("{{baseName}}");
        {{#required}}
        if (({{paramName}} == null || ((File) {{paramName}}.getFile()).length() == 0)) {
            throw new IllegalArgumentException("'{{baseName}}' file cannot be empty");
        }
        {{/required}}
        {{/notFile}}
        {{#notFile}}
        {{#collectionFormat}}
        String[] {{paramName}}Array = request().body().asMultipartFormData().asFormUrlEncoded().get("{{baseName}}");
        {{#required}}
        if ({{paramName}}Array == null) {
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
        }
        {{/required}}
        List<String> {{paramName}}List = SwaggerUtils.parametersToList("{{collectionFormat}}", {{paramName}}Array);
        {{{dataType}}} {{paramName}} = new Array{{{dataType}}}();
        for (String curParam : {{paramName}}List) {
            if (!curParam.isEmpty()) {
                //noinspection UseBulkOperation
                {{paramName}}.add({{>itemConversionBegin}}curParam{{>itemConversionEnd}});
            }
        }
        {{/collectionFormat}}
        {{^collectionFormat}}
        String value{{paramName}} = (request().body().asMultipartFormData().asFormUrlEncoded().get("{{baseName}}"))[0];
        {{{dataType}}} {{paramName}};
        if (value{{paramName}} != null) {
            {{paramName}} = {{>conversionBegin}}value{{paramName}}{{>conversionEnd}};
        } else {
            {{#required}}
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
            {{/required}}
            {{^required}}
            {{paramName}} = {{>paramDefaultValue}};
            {{/required}}
        }
        {{/collectionFormat}}
        {{/notFile}}
        {{/formParams}}
        {{#headerParams}}
        {{#collectionFormat}}
        String[] {{paramName}}Array = request().headers().get("{{baseName}}");
        {{#required}}
        if ({{paramName}}Array == null) {
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
        }
        {{/required}}
        List<String> {{paramName}}List = SwaggerUtils.parametersToList("{{collectionFormat}}", {{paramName}}Array);
        {{{dataType}}} {{paramName}} = new Array{{{dataType}}}();
        for (String curParam : {{paramName}}List) {
            if (!curParam.isEmpty()) {
                //noinspection UseBulkOperation
                {{paramName}}.add({{>itemConversionBegin}}curParam{{>itemConversionEnd}});
            }
        }
        {{/collectionFormat}}
        {{^collectionFormat}}
        String value{{paramName}} = request().getHeader("{{baseName}}");
        {{{dataType}}} {{paramName}};
        if (value{{paramName}} != null) {
            {{paramName}} = {{>conversionBegin}}value{{paramName}}{{>conversionEnd}};
        } else {
            {{#required}}
            throw new IllegalArgumentException("'{{baseName}}' parameter is required");
            {{/required}}
            {{^required}}
            {{paramName}} = {{>paramDefaultValue}};
            {{/required}}
        }
        {{/collectionFormat}}
        {{/headerParams}}
        {{^controllerOnly}}
        {{^returnType}}
        {{#supportAsync}}
        return CompletableFuture.supplyAsync(() -> {
        {{/supportAsync}}
        {{/returnType}}
        {{#returnType}}{{#supportAsync}}CompletionStage<{{>returnTypesNoVoid}}> stage = {{/supportAsync}}{{^supportAsync}}{{>returnTypesNoVoid}} obj = {{/supportAsync}}{{/returnType}}{{^returnType}}{{#supportAsync}}    {{/supportAsync}}{{/returnType}}imp.{{operationId}}({{#allParams}}{{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}}){{#returnType}}{{#supportAsync}}.thenApply(obj -> { {{/supportAsync}}{{/returnType}}{{^supportAsync}};{{/supportAsync}}
        {{#returnType}}
        {{^isResponseFile}}
        {{^returnTypeIsPrimitive}}
        {{#useBeanValidation}}
        {{^supportAsync}}
        if (configuration.getBoolean("useOutputBeanValidation")) {
            {{#isListContainer}}
            for ({{{returnType}}} curItem : obj) {
                SwaggerUtils.validate(curItem);
            }
            {{/isListContainer}}
            {{#isMapContainer}}
            for (Map.Entry<String, {{{returnType}}}> entry : obj.entrySet()) {
                SwaggerUtils.validate(entry.getValue());
            }
            {{/isMapContainer}}
            {{^returnContainer}}
            SwaggerUtils.validate(obj);
            {{/returnContainer}}
        }
        {{/supportAsync}}
        {{#supportAsync}}
            if (configuration.getBoolean("useOutputBeanValidation")) {
                {{#isListContainer}}
                for ({{{returnType}}} curItem : obj) {
                    SwaggerUtils.validate(curItem);
                }
                {{/isListContainer}}
                {{#isMapContainer}}
                for (Map.Entry<String, {{{returnType}}}> entry : obj.entrySet()) {
                    SwaggerUtils.validate(entry.getValue());
                }
                {{/isMapContainer}}
                {{^returnContainer}}
                SwaggerUtils.validate(obj);
                {{/returnContainer}}
            }
        {{/supportAsync}}
        {{/useBeanValidation}}
        {{/returnTypeIsPrimitive}}
        {{/isResponseFile}}
        {{#supportAsync}}
            return obj;
        });
        {{/supportAsync}}
        {{/returnType}}
        {{#returnType}}
        {{#supportAsync}}
        stage.thenApply(obj -> {
        {{/supportAsync}}
        {{^isResponseFile}}
        {{#supportAsync}}    {{/supportAsync}}JsonNode result = mapper.valueToTree(obj);
        {{#supportAsync}}    {{/supportAsync}}return ok(result);
        {{/isResponseFile}}
        {{#isResponseFile}}
        {{#supportAsync}}    {{/supportAsync}}return ok(obj);
        {{/isResponseFile}}
        {{/returnType}}
        {{^returnType}}
        {{#supportAsync}}    {{/supportAsync}}return ok();
        {{/returnType}}
        {{#supportAsync}}
        });
        {{/supportAsync}}
        {{/controllerOnly}}
        {{#controllerOnly}}
        return ok();
        {{/controllerOnly}}
    }
{{/operation}}
}
{{/operations}}

ignaciomolina · 2018-03-07T20:17:01Z

Ok, I already add the changes and regenerate the samples, I am not fun of duplicating the validation block just to add tabulation though

JFCote · 2018-03-07T20:47:44Z

I am not fun of duplicating the validation block just to add tabulation though
Yeah me too. If someone else has a better way to do it, I'm listening.
But it does the work!

JFCote · 2018-03-08T12:58:50Z

modules/swagger-codegen/src/main/resources/JavaPlayFramework/newApiController.mustache

@@ -215,21 +226,50 @@ public class {{classname}}Controller extends Controller {
            SwaggerUtils.validate(obj);
            {{/returnContainer}}
        }
+        {{/supportAsync}}
+        {{#supportAsync}}


@wing328 I helped @ignaciomolina with his PR by suggesting this solution. To have good tabulation, we need to duplicate stuff in the mustache file (look here for the bean validation).
Any idea to do it more cleanly? Otherwise, this PR looks good to me!

@JFCote agreed with you that some files or code (refactored into mustache partial) can be reused between different generators. I've some ideas but would require moving files around (which is not an elegant solution).

@wing328 I'm not talking about moving stuff between generators, I'm talking about duplicated stuff in this mustache file. The line that is highlighted. There is the version with supportAsync without tabulation and the version without supportAsync that doesn't have any tabulation. The code is duplicated.

I was wondering if there was a better way to do that?

@JFCote ah ok. Just went through the mustache file you provided.

What about creating another file newApiControllerAsync.mustache instead of using {{#supportAsync}} .. {{/supportAsync}} in newApiController.mustache? The drawback is that we must remember applying the same enhancement/bug fixes to both files.

That's even worse than duplicate a chunk of code xD
Maybe the best solution was the first, to just add {{#supportAsync}} {{/supportAsync}} in front each line of the block 😓

JFCote · 2018-03-20T17:08:09Z

By the way @wing328 , this is ok for merging I think

ignaciomolina added 4 commits February 21, 2018 17:14

Add property 'supportAsync' to allow the use of CompletionStage of java8

cb86df7

Add support for completionStage in play-framework templates

ed4d6b4

Add script to generate samples for play-framework async controllers

8f8d264

Add generated samples for java play framework with asynchronous contr…

b9eb766

…ollers

ignaciomolina closed this Feb 21, 2018

Add missing templates and generate samples

a06569f

ignaciomolina reopened this Feb 21, 2018

JFCote suggested changes Feb 21, 2018

View reviewed changes

ignaciomolina added 4 commits February 22, 2018 10:11

Remove useless comments from generated samples in play framework async

6ad695d

Fix ControllerImp template for java play framework

a2c6166

Add script for java play framework async to general script

68cf882

Regenerate java play framework server samples

94c5345

JFCote suggested changes Feb 22, 2018

View reviewed changes

ignaciomolina added 8 commits February 22, 2018 18:38

Fix missing whitespace

d019eae

Fix unnecessary blank lines at imports

f2d25d0

Fix tabulation issue

5439864

Fix tabulation issue in controllers

3b9c192

Remove blanks from api Imp

a88e8c8

Remove more empty lines

fde48b2

Add blank between methods

fac415f

Remove blanks before call to service method

8712731

ignaciomolina added 2 commits March 7, 2018 21:12

Fix some tabulations in java play async templates

51fd122

Regenerate samples for java play async

e06a6fb

JFCote reviewed Mar 8, 2018

View reviewed changes

wing328 added the Client: Java label Mar 8, 2018

wing328 added this to the v2.4.0 milestone Mar 8, 2018

wing328 merged commit c91ce17 into swagger-api:master Apr 9, 2018

wing328 added Enhancement: Feature Server: Java and removed Client: Java labels Apr 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/javaPlayWithAsynchronousControllers #7705

Feature/javaPlayWithAsynchronousControllers #7705

ignaciomolina commented Feb 21, 2018 •

edited

Loading

JFCote left a comment

JFCote Feb 21, 2018

ignaciomolina Feb 22, 2018

JFCote Feb 21, 2018

JFCote Feb 21, 2018

JFCote Feb 21, 2018

ignaciomolina commented Feb 22, 2018

JFCote left a comment

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

ignaciomolina Feb 22, 2018

JFCote Feb 22, 2018

ignaciomolina Feb 22, 2018

JFCote Feb 22, 2018

ignaciomolina Feb 22, 2018

JFCote Feb 22, 2018

JFCote Feb 22, 2018

JFCote commented Feb 23, 2018

JFCote commented Mar 1, 2018

JFCote commented Mar 6, 2018

JFCote commented Mar 7, 2018 •

edited

Loading

ignaciomolina commented Mar 7, 2018

JFCote commented Mar 7, 2018

JFCote Mar 8, 2018

wing328 Mar 8, 2018

JFCote Mar 8, 2018 •

edited

Loading

wing328 Mar 8, 2018

ignaciomolina Mar 9, 2018 •

edited

Loading

JFCote commented Mar 20, 2018

		@@ -17,6 +17,7 @@
		import swagger.SwaggerUtils;
		import com.fasterxml.jackson.core.type.TypeReference;

Feature/javaPlayWithAsynchronousControllers #7705

Feature/javaPlayWithAsynchronousControllers #7705

Conversation

ignaciomolina commented Feb 21, 2018 • edited Loading

PR checklist

Description of the PR

JFCote left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignaciomolina commented Feb 22, 2018

JFCote left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JFCote commented Feb 23, 2018

JFCote commented Mar 1, 2018

JFCote commented Mar 6, 2018

JFCote commented Mar 7, 2018 • edited Loading

ignaciomolina commented Mar 7, 2018

JFCote commented Mar 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JFCote Mar 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignaciomolina Mar 9, 2018 • edited Loading

Choose a reason for hiding this comment

JFCote commented Mar 20, 2018

ignaciomolina commented Feb 21, 2018 •

edited

Loading

JFCote commented Mar 7, 2018 •

edited

Loading

JFCote Mar 8, 2018 •

edited

Loading

ignaciomolina Mar 9, 2018 •

edited

Loading