[Ada] by defining x-is-model-type when property is local to the YML file #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcular dependencies between gpr files.
…ined locally in the YML file. Fix #7569.
|
@micheleISEP thanks for the PR. cc @stcarrez to review |
|
It took me time to look at it but yes, this is truly correct! |
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
WIth these changes, postProcessModels method of AbstractAdaCodegen class adds "x-is-model-type true" to all the properties of a model that are related to models defined in the same YML file. The change was done to Fix #7569.
Tests were done against both the YML file in issue 7569, and against 2 quite complex YML files. One of the YML specifications was previously processed correctly, and still is. The other one was not correctly processed, and now produces correct code.
Please Stephane verify my changes, since I am not sure why you had a "List d" in method postProcessModels.