Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Changes hard coded body to dynamic parameter name - Fixes #6569 #7630

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

aykutakin
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Changed to {{paramName}} instead of body. Otherwise generated code cannot be compiled since method parameter is named with {{paramName}} and there is no variable named body.

Test has been done with suggested yaml:

paths:
  '/ExampleResource':
    post:
      summary: Example
      parameters:
        - in: body
          name: body_param_name
          schema:
            $ref: '#/definitions/Example'
      responses:
        '200':
          description: Successful operation.
definitions:
  Example:
    description: "example"
    type: string

@wing328
Copy link
Contributor

wing328 commented Feb 10, 2018

@aykutakin thanks for the PR, which looks good to me.

@wing328 wing328 added this to the v2.4.0 milestone Feb 10, 2018
@wing328 wing328 merged commit 0b845a5 into swagger-api:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants