Fixed unicode error and supported allow_nonstandard_methods in tornado based python client #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shwetas1205 thanks for PR. cc @taxpon @frol @mbohlool @cbornet @kenjones-cisco for review. |
|
LGTM Thanks for the PR. |
|
LGTM @shwetas1205 Thank you for the fix! |
|
@shwetas1205 thanks for the PR, which has been merged into master. @kenjones-cisco @frol thanks for the prompt review of this PR. |
|
Awesome. Thanks a lot @wing328 @frol @kenjones-cisco for the quick turnaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR will fix #7559 and #7109
Setting allow_nonstandard_methods flag by default to TRUE to make sure that tornado client can be used for DELETE and other methods with body.
six.u does not support Unicode as an input and end up throwing exception in python2 for unicode inputs. Now, using six.text_type to for reliable conversion.