Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object definition returned in nested array/map to the imports #7445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gurubook
Copy link

Description of the PR

Code generation on operation that return object in "nested" array/map does not add the required definition to the import list.
This patch address the issue saving the contained object type during the recursion.
This should solve issue #7444

@wing328
Copy link
Contributor

wing328 commented Jan 22, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Contributor

wing328 commented Jan 22, 2018

Please use spaces intead of tab.

Also can you share a spec to reproduce the issue?

added return-nested.yaml spec that prove the point
@gurubook
Copy link
Author

Fixed indentation issue and added return-nested.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants