Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Vertx] use reflection to instantiate non-generated class #7360

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

ccozzolino
Copy link
Contributor

@ccozzolino ccozzolino commented Jan 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix for #7359

Fixed async and rx versions of the vertx server generated samples. Use reflection to delay instantiation of a non-generated class dependency.

Bumped swagger router version from 1.2.0 to 1.4.0.

Fixed some formatting in the sample pom.xml files.

@wing328 @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09)

@wing328 wing328 modified the milestones: v2.4.0, v2.3.1 Jan 11, 2018
@wing328
Copy link
Contributor

wing328 commented Jan 11, 2018

@ccozzolino thanks for the fix. Tests passed via https://circleci.com/gh/swagger-api/swagger-codegen/3346

@wing328 wing328 merged commit 247fbd4 into swagger-api:master Jan 11, 2018
@wing328 wing328 changed the title #7359 Fix - use reflection to instantiate non-generated class [Java][Vertx] use reflection to instantiate non-generated class Jan 13, 2018
wing328 pushed a commit that referenced this pull request Jan 14, 2018
* #7359 Fix - use reflection to instantiate non-generated class (#7360)

* add tests for java vertx petstore

* add swagger example to README.md (#7368)

* Fix assignment of new object instance to variable

Fixes `Error in foobar$fromJSONString(s) : object 'CategoryObject' not found`
Discussion in #6520 (comment) ,
thanks @wing328 for encouraging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants