[Java/GSON] Fix error with enums of integer type #7059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
craffael
changed the title
# Conflicts: # samples/client/petstore/java/okhttp-gson-parcelableModel/pom.xml # samples/server/petstore/java-msf4j/src/gen/java/io/swagger/api/FakeApi.java
|
@bbdouglas @sreeshas @jfiala @lukoyanov What do you think? |
|
Any Chance this will be part of an upcoming release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This is the second attempt to fix issue #6806 . The first attempt (PR #7051) introduced a new variable to
CodegenModel.javawhich was rather ugly. The present fix uses an entirely different approach by rewriting the GSON adapter for enums, i.e. only two mustache templates have to be changed.I have tested the generated code with enums of type string and integer and it worked in both cases. This solution essentially relies on special behavior of com.google.gson.stream.JsonReader#nextString().