[TypeScript][Angular] Fixed spacing in model.mustache #6788
Conversation
|
Note @wing328 I see we have run-all-petstore.cmd that's run by appveyor but they are multiple *-all.bat files. This means tests are taking longer than needed due to double generating templates. Should we just include *-all.bat and update the appveyor script or should we in the appveyor script just exclude once that have -all in them? |
…s instead of just angular.
| @@ -10,7 +10,6 @@ export interface {{classname}} {{#parent}}extends {{{parent}}} {{/parent}}{ | |||
| */ | |||
| {{/description}} | |||
| {{name}}{{^required}}?{{/required}}: {{#isEnum}}{{{datatypeWithEnum}}}{{/isEnum}}{{^isEnum}}{{{datatype}}}{{/isEnum}}; | |||
|
|
|||
| } | ||
|
|
There was a problem hiding this comment.
But do you know where these two lines come from? Why two?
There was a problem hiding this comment.
dangit.... I think I accidentally added another one after the simple eol. I can go back and change that lol
There was a problem hiding this comment.
turns out it wasn't me. It was there incorrectly from the enum generator
There was a problem hiding this comment.
@kenisteward ah I see. I'll create a PR to get rid of them eventually, unless anybody sees any value in having two empty lines at the end.
@kenisteward maybe better to exclude *-all.bat |
|
@kenisteward the PR looks good |
wing328
changed the title
|
So in the model.mustache we include modelgeneric and enumgeneric. Whenever
there are nested mustaches it seems it takes all the end of file lines from
all of them. Therefore if we have every mustache with end of file lines we
end up with more than we want in the output. I've fixed the output by
simply adding one end line on the outer mustache and removing ones from the
inserted.
…On Tue, Oct 24, 2017, 4:06 AM Sebastian Haas ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
samples/client/petstore/typescript-angular-v2/default/model/ApiResponse.ts
<#6788 (comment)>
:
> }
+
@kenisteward <https://github.com/kenisteward> ah I see. I'll create a PR
to get rid of them eventually, unless anybody sees any value in having two
empty lines at the end.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6788 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMPLtdumPZ8uo9pQ9FNOqgSmaCS0I1B8ks5svZqcgaJpZM4QDMkj>
.
|
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
@sebastianhaas @wing328
An extra line was being added in models. See any an example in the PR here #6757
Also amended typscript-angular2-all.bat and .sh to include angular 4 and angular 4.3 generation.