Issue 5978 #6431
Issue 5978 #6431
Conversation
| @@ -65,7 +65,7 @@ export default class {{classname}} {{#parent}}{{^parentModel}}{{#vendorExtension | |||
| * @member {{=< >=}}{<&vendorExtensions.x-jsdoc-type>}<={{ }}=> {{baseName}}{{#defaultValue}} | |||
| * @default {{{defaultValue}}}{{/defaultValue}} | |||
| */{{/emitJSDoc}} | |||
| {{baseName}} = {{#defaultValue}}{{{defaultValue}}}{{/defaultValue}}{{^defaultValue}}undefined{{/defaultValue}}; | |||
| {{name}} = {{#defaultValue}}{{{defaultValue}}}{{/defaultValue}}{{^defaultValue}}undefined{{/defaultValue}}; | |||
There was a problem hiding this comment.
@CodeNinjai I still think this should be {{name}} instead of {{baseName}}
e.g. {{baseName}} (original name specified in the spec) can be "modified-date" while {{name}} is the variable name following JS style guide (e.g. modified_date)
There was a problem hiding this comment.
@wing328 So that what the change does, doesn't it? It changes {{ baseName }} to {{ name }}.
There was a problem hiding this comment.
@frol ah sorry. You're right. I misread.
| @@ -500,7 +509,7 @@ public String toVarName(String name) { | |||
|
|
|||
| // camelize (lower first character) the variable name | |||
| // pet_id => petId | |||
| name = camelize(name, true); | |||
| //name = camelize(name, true); | |||
There was a problem hiding this comment.
@CodeNinjai Commenting out camelize will probably impact JS ES5 output as well. Shall we keep it as it's?
There was a problem hiding this comment.
@CodeNinjai Given the code style guides for JS, camel-case should be used for variable and method names. Please, bring it back.
Also, it seems that the custom name.matches(...) should be simply placed into sanitizeName once instead of copy-pasting.
| // Browser globals (root is window) | ||
| factory(root.expect, root.{{moduleName}}); | ||
| } | ||
|
|
There was a problem hiding this comment.
How is this going to work? The module will be empty since the factory isn't called.
| @@ -1,19 +1,12 @@ | |||
| {{>licenseInfo}} | |||
| import expect, { createSpy, spyOn, isSpy } from 'expect'; | |||
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
Fixes #5978