[Java][Spring] Fix spring cloud client due to enhancement in adding server example responses. #5497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
changed the title
|
Wouldn't it be easier to have some "returnExamples" additionalProperty that is false for spring-cloud and that equals "examples" for the other ? |
|
@cbornet thanks for the suggestion. I think the challenge lies in the fact that both client and server share the same templates and I believe we still need the Anyway feel free to submit a PR to further enhance the template after this PR is merged into master. |
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…erver example responses. (swagger-api#5497) * add use spring cloud client option * uncomment spring cloud client test * remove scala-related tests from pom.xml for circleci * fix mismstach tag
cbornet
reviewed
Oct 16, 2017
| @@ -17,8 +17,10 @@ import org.springframework.web.bind.annotation.RequestHeader; | |||
| import org.springframework.web.bind.annotation.RequestParam; | |||
| import org.springframework.web.bind.annotation.RequestPart; | |||
| import org.springframework.web.multipart.MultipartFile; | |||
| {{^useSpringCloudClient}} | |||
There was a problem hiding this comment.
Spring cloud client doesn't generate the apiController so I guess this is not needed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
To fix #5432