Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Minor improvements to Configuration php template #4989

Merged
merged 1 commit into from
Mar 9, 2017
Merged

[PHP] Minor improvements to Configuration php template #4989

merged 1 commit into from
Mar 9, 2017

Conversation

baartosz
Copy link
Contributor

@baartosz baartosz commented Mar 9, 2017

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Small improvements, mostly stuff pointed out by phpstorm checks regarding
#3867

@wing328
Copy link
Contributor

wing328 commented Mar 9, 2017

@baartosz LGTM. Thanks for the enhancement.

cc @arnested

@wing328 wing328 merged commit cffaaa0 into swagger-api:master Mar 9, 2017
@wing328 wing328 changed the title minor improvements to Configuration php template [PHP] Minor improvements to Configuration php template Mar 12, 2017
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants