Typescript angular2 typings #4795

BastiOfBerlin · 2017-02-14T10:19:21Z

This also removes the dependency to the typings project.
Issue #4761

PR checklist

Read the contribution guildelines.
Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

This PR changes the way typescript's typings are resolved, from the old-way of utilizing the typings project to using @types/* npm packages, which is the default way for typescript2.

A big drawback of the typings project was that it could not be installed offline and relied on an own registry.

The README has also been updated to reflect the changes, outline the use of @angular/cli's environments and show how to use npm link.

This update allows the root Dockerfile to be used as a development container and updates run-in-docker.sh to use the same entrypoint script while maintaining backward compatibility for anyone who has scripted mappings to /gen and /root/.m2/repository.

…codegen into jimschubert-dockerfiles

… api templates

Signed-off-by: weiyang <weiyang.ones@gmail.com>

…d parameter in path parameter (#4457) Closes #4391

…#4500)

When a string enumeration has the empty string as one of its available values, the generated code for many languages is invalid because the empty string can not be used as an identifier. As with numbers and symbols, provide a mapping to an English name which can be used as a replacement. In this case, "empty" for the empty string/empty value. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

…required switch, in place of only show the field type by default (#4489)

Issue 3925

* Fix Gson parsing of Joda DateTime without millis The DateTimeFormatter returned by ISODateTimeFormat.dateTime() only parses dates with millisecond values, and throws IllegalArgumentException when milliseconds are not present. The date-time construct from RFC 3339 Section 5.6 referenced by the Swagger/OpenAPI spec allows fractional second values to be omitted. This results in valid date-time values being rejected by the generated code. This commit fixes the problem by using .dateOptionalTimeParser() for parsing, which correctly handles date-time values without fractional seconds. A previous version of this commit used .dateTimeParser(), which accepted a time without a date and was considered too liberal. Note that .dateTime() must still be used for printing, which is not supported by .dateTimeParser(). Signed-off-by: Kevin Locke <kevin@kevinlocke.name> * Fix akka-scala date-time parser with Joda As in the previous commit, which fixed Java generators, ISOISODateTimeFormat.dateOptionalTimeParser() should be used for date-time parsing and ISOISODateTimeFormat.dateTime() for printing. Apply the same change to akka-scala. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

* [swift3] allow POST with both body and query parameters * Correctly support non-string and optional query parameters.

updated version

* Preliminary implementation for issue-4416 * Updated README.md with reserved-words-mappings parameter.

* Fixes for issue 4226. Detects and warns about more than one inline object; sets discriminator on CodegenModel; Adds templates to other Java languages Changes to be committed: modified: modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java modified: modules/swagger-codegen/src/main/resources/Java/typeInfoAnnotation.mustache new file: modules/swagger-codegen/src/main/resources/JavaInflector/typeInfoAnnotation.mustache new file: modules/swagger-codegen/src/main/resources/JavaJaxRS/typeInfoAnnotation.mustache new file: modules/swagger-codegen/src/main/resources/JavaSpring/typeInfoAnnotation.mustache * Add vendor extension for x-discriminator-value Changes to be committed: modified: modules/swagger-codegen/src/main/resources/Java/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaInflector/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaJaxRS/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaSpring/typeInfoAnnotation.mustache * Add "visible = true" to @JsonTypeInfo jackson annotations for Java languages Changes to be committed: modified: modules/swagger-codegen/src/main/resources/Java/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaInflector/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaJaxRS/typeInfoAnnotation.mustache modified: modules/swagger-codegen/src/main/resources/JavaSpring/typeInfoAnnotation.mustache

* add script to detect carriage return * add check for generator as well * add fail fast to travis config * remove tab * move scripts under bin/utils * remove carriage return * move scripts to bin/utils

[dockerfile] Replace 'maven:3.3-jdk-7' with 'maven:3-jdk-7-alpine'

* remove jersey templates #4720 * regenerate sample with jaxrs-spec templates #4720

…tor (#4740) * [Java-Feign] Fixed String comparison using equals instead of == operator * [Java-Feign] Updated ApiClient with ./bin/java-petstore-feign.sh

…egen into MatanRubin-uuid-type

* [Java-Feign] Fixed String comparison using equals instead of == operator * [Java-Feign] Updated ApiClient with ./bin/java-petstore-feign.sh * [Java-retrofit] Fix for #4750 String comparison with equals

This also removes the dependency to the typings project. Issue #4761

BastiOfBerlin · 2017-02-14T10:21:27Z

Since this might be a breaking change (depending on typescript 2), I filed the PR against 2.3.0, but I developed against master, resulting in a bunch of conflicting files. Hope you can help to merge? @wing328 ?

kenisteward · 2017-02-15T15:58:34Z

@BastiOfBerlin I have made a PR that I expect will be merged soon either to this or to master. (#4766) In that it changes the abstract typescript to generate typings for all. I will be making another PR to update those to only use @types instead but this should be done at the Abstract scale not per client

BastiOfBerlin · 2017-02-22T12:04:31Z

@kenisteward When do you expect this to work? Maybe it makes sense to work together?

wing328 · 2017-03-17T14:14:26Z

@BastiOfBerlin I think what I'll do is to cherry-pick 9444c49

wing328 · 2017-06-26T15:56:57Z

@kenisteward are you ok if I just cherry-pick 9444c49?

For #4766 (comment), if you've completed the test and it's ready for merge, let me know.

kenisteward · 2017-06-26T16:03:49Z

@wing328 looking at 9444c49 it looks like you should be able to chery-pick it okay.

As far as #4766 goes I have not tested with all current changes yet. I may have time next week to do this but I will be in the middle of trying to integrate the changes from SCGen 2.3.0 into our build process.

wing328 · 2017-06-26T16:17:10Z

@kenisteward thanks for reviewing. I'll do it tomorrow with a new PR

cc @BastiOfBerlin

wing328 · 2017-07-27T14:54:37Z

Closed via #5966

jimschubert and others added 30 commits May 23, 2016 21:54

[docker] Cleanup and reduce container sizes

1da350e

Limit base image to 1.0

b2c14c9

[docker] Runnable CLI, reduced container size

fe66364

[docker] Add container docs and example usage

b996d0c

Merge branch 'dockerfiles' of https://github.com/jimschubert/swagger-…

4f92194

…codegen into jimschubert-dockerfiles

Adjust Date ISO Dateformat for Query Parameters

98aaa1f

[JAX-RS RESTEasy][issue #4447] Added swagger annotations to model and…

ababec6

… api templates

[JAX-RS RESTEasy][issue #4447] Updated RESTEasy petstore samples

45002ec

[dockerfile] Replace 'maven:3.3-jdk-7' with 'maven:3-jdk-7-alpine'

6b0b7a1

Signed-off-by: weiyang <weiyang.ones@gmail.com>

add beanvalidation to jersey1 and jersey2 #4091

1a1d0ae

add safe argument to quote method in python template to avoid unquote…

6a080d3

…d parameter in path parameter (#4457) Closes #4391

Fixes #4481 (#4493)

b224474

Updated Nancy from 1.4.1 to 1.4.3 (#4482)

aa1dc0f

Adding Curl connect timeout configuration to PHP generation templates (…

43ab14b

…#4500)

[html2] Open the description field that contains the description and …

c0f1716

…required switch, in place of only show the field type by default (#4489)

Allow templates to use maxItems and minItems for Arrays (#4309)

5686109

Issue 3925

update jaxrs jersey1 templates and sample output #4091

dde24eb

update language jaxrs (Jersey2) and samples

5b532fd

add test for options #4091

24f4861

add check for isInteger (integer/decimal)

6b17b92

[swift3] allow POST with both body and query parameters (#4490)

1e8c718

* [swift3] allow POST with both body and query parameters * Correctly support non-string and optional query parameters.

updated version

69b1e50

Merge pull request #4521 from swagger-api/issue-4478

ccf6f02

updated version

Enable support for vendor extensions in CodegenResponse. (#4517)

81b5b78

Issue 4416 (Assist escapeReservedWord with custom mappings) (#4480)

26ead9b

* Preliminary implementation for issue-4416 * Updated README.md with reserved-words-mappings parameter.

[CI] Add scripts to detect carriage return and tab (#4526)

4d4af71

* add script to detect carriage return * add check for generator as well * add fail fast to travis config * remove tab * move scripts under bin/utils * remove carriage return * move scripts to bin/utils

fehguy and others added 15 commits February 7, 2017 10:35

Merge pull request #4487 from wy-z/dockerfile_update_base_image

73cfc84

[dockerfile] Replace 'maven:3.3-jdk-7' with 'maven:3-jdk-7-alpine'

[Jaxrs-spec] fix usage of Jersey templates in shellscript (#4722)

e9823a8

* remove jersey templates #4720 * regenerate sample with jaxrs-spec templates #4720

update jaxrs spec petstore sample (mac)

bdf6957

add SPINEN

69edf28

[Java-Feign] Fixed String comparison using equals instead of == opera…

2179b44

…tor (#4740) * [Java-Feign] Fixed String comparison using equals instead of == operator * [Java-Feign] Updated ApiClient with ./bin/java-petstore-feign.sh

Merge branch 'uuid-type' of https://github.com/MatanRubin/swagger-cod…

7998a30

…egen into MatanRubin-uuid-type

update java petstore with new uuid mapping

882c3ec

update java server stub samples with new uuid mapping

beadd6d

Merge branch 'MatanRubin-uuid-type'

08aef95

Merge branch 'master' of https://github.com/swagger-api/swagger-codegen

d91135e

[Java-retrofit] Fix for #4750 String comparison with equals (#4751)

0d14496

* [Java-Feign] Fixed String comparison using equals instead of == operator * [Java-Feign] Updated ApiClient with ./bin/java-petstore-feign.sh * [Java-retrofit] Fix for #4750 String comparison with equals

remove default temp folder during initalization (#4749)

ef31efe

merged

8fa2ef8

Merge branch 'jimschubert-dockerfiles'

93a63db

Updated npm configuration to use new typescript2 typings system

9444c49

This also removes the dependency to the typings project. Issue #4761

wing328 mentioned this pull request Feb 15, 2017

All typescript client should have to possibility to generate packaging information #2694

Open

wing328 added the Client: TypeScript label Feb 15, 2017

wing328 added this to the v2.3.0 milestone Feb 15, 2017

wing328 added Enhancement: Feature Breaking change (without fallback) labels Feb 15, 2017

wing328 mentioned this pull request Mar 13, 2017

[typescript-angular2] Suggestions for refactoring (baseUrl, url service, npm module) #4971

Open

wing328 closed this Jul 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Typescript angular2 typings #4795

Typescript angular2 typings #4795

Uh oh!

BastiOfBerlin commented Feb 14, 2017

Uh oh!

BastiOfBerlin commented Feb 14, 2017

Uh oh!

kenisteward commented Feb 15, 2017

Uh oh!

BastiOfBerlin commented Feb 22, 2017

Uh oh!

wing328 commented Mar 17, 2017

Uh oh!

wing328 commented Jun 26, 2017

Uh oh!

kenisteward commented Jun 26, 2017

Uh oh!

wing328 commented Jun 26, 2017

Uh oh!

wing328 commented Jul 27, 2017

Uh oh!

Uh oh!

Typescript angular2 typings #4795

Typescript angular2 typings #4795

Uh oh!

Conversation

BastiOfBerlin commented Feb 14, 2017

PR checklist

Description of the PR

Uh oh!

BastiOfBerlin commented Feb 14, 2017

Uh oh!

kenisteward commented Feb 15, 2017

Uh oh!

BastiOfBerlin commented Feb 22, 2017

Uh oh!

wing328 commented Mar 17, 2017

Uh oh!

wing328 commented Jun 26, 2017

Uh oh!

kenisteward commented Jun 26, 2017

Uh oh!

wing328 commented Jun 26, 2017

Uh oh!

wing328 commented Jul 27, 2017

Uh oh!

Uh oh!