Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS generator - Harken to the the warnings ... #3494

Merged
merged 1 commit into from
Aug 1, 2016
Merged

NodeJS generator - Harken to the the warnings ... #3494

merged 1 commit into from
Aug 1, 2016

Conversation

osher
Copy link
Contributor

@osher osher commented Aug 1, 2016

2 types of warnings are emitted in bulk whenever using the nodeJS generator:

[main] WARN io.swagger.codegen.DefaultCodegen - escapeUnsafeCharacters should be overriden in the code generator with proper logic to escape unsafe characters

and

[main] WARN io.swagger.codegen.DefaultCodegen - escapeQuotationMark should be overriden in the code generator with proper logic to escape single/double quote

I did some guesswork: since JS is a c-type language like C# and Java - I looked there for reference, and followed their example.

2 types of warnings are emitted in bulk whenever using the nodeJS generator.

I did some guesswork: since JS is a c-type language like C# and Java - I looked there for reference, and followed their example.
@osher
Copy link
Contributor Author

osher commented Aug 1, 2016

uhhh....
how do I label it as Server: Nodejs ?

@wing328
Copy link
Contributor

wing328 commented Aug 1, 2016

@osher the change looks good to me. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants