Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP][C#] better enum support #2508

Merged
merged 26 commits into from
May 3, 2016
Merged

[PHP][C#] better enum support #2508

merged 26 commits into from
May 3, 2016

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented Apr 6, 2016

Better enum support for numbers and special characters

@bherila
Copy link
Contributor

bherila commented Apr 10, 2016

This also impacts typescript-node

@wing328
Copy link
Contributor Author

wing328 commented Apr 11, 2016

@bherila thanks for pointing it out. This is going to be a major change and I'll need to fix all other languages that supports enum.

@wing328
Copy link
Contributor Author

wing328 commented Apr 29, 2016

UPDATE: rebased on the latest to provide better enum support for the following:

PHP, Java, C#, JAX-RS, Spring

@wing328
Copy link
Contributor Author

wing328 commented May 25, 2016

Upgrade note from 2.1.6 to 2.2.0

For better enum support (e.g. integer, special characters) we changed the following

public List<String> allowableValues;

to

public Map<String, Object> allowableValues;

Please update your code accordingly if your code has a dependency on allowableValues

@clicktravel-chrishern
Copy link

Hi,

We are interested in using the enhancements in this PR. Do you have any idea when version 2.2.0 will be released?

@wing328
Copy link
Contributor Author

wing328 commented Jun 22, 2016

@wing328 wing328 deleted the php_enum branch June 22, 2016 13:01
@bherila
Copy link
Contributor

bherila commented Jun 23, 2016

@clicktravel-chrishern Here is my local build:
https://1drv.ms/u/s!AlvOZGwys91vxq5GV6WaZpNz9aQoog

Hope it helps, use at your own risk!

Cheers,
Ben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants