Update retrofit2 and retrofit2rx to use retrofit 2.0.1 #2479

kungfoo · 2016-03-31T16:22:40Z

We need the updated libs, so I thought I'd cherrypick to your version.

kungfoo · 2016-03-31T16:35:43Z

The samples are not updated automatically, so I'll still have to add that. Right?

wing328 · 2016-04-01T04:14:00Z

Here are some errors reported in the CI:

[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[19,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[20,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[21,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[310,17] error: cannot find symbol
[ERROR] 
    T extends Object declared in class GsonResponseBodyConverterToString
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[313,37] error: cannot find symbol
[ERROR] 
    T extends Object declared in class GsonResponseBodyConverterToString
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[331,49] error: cannot find symbol
[ERROR]  class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[335,17] error: cannot find symbol
[ERROR]  class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[336,17] error: cannot find symbol
[ERROR]  class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[338,38] error: cannot find symbol

Maybe you forgot to add some new files?

kungfoo · 2016-04-01T06:28:13Z

Hmm, since I've cherry picked the change, I probably missed one of the libs
when resolving conflicts. I'll look into it once I get to the office.

On Fri, 1 Apr 2016, 06:14 wing328, notifications@github.com wrote:

Here are some errors reported in the CI:

[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[19,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[20,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[21,22] error: package com.google.gson does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[310,17] error: cannot find symbol
[ERROR]
T extends Object declared in class GsonResponseBodyConverterToString
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[313,37] error: cannot find symbol
[ERROR]
T extends Object declared in class GsonResponseBodyConverterToString
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[331,49] error: cannot find symbol
[ERROR] class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[335,17] error: cannot find symbol
[ERROR] class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[336,17] error: cannot find symbol
[ERROR] class GsonCustomConverterFactory
/home/travis/build/swagger-api/swagger-codegen/samples/client/petstore/java/retrofit2/src/main/java/io/swagger/client/ApiClient.java:[338,38] error: cannot find symbol

Maybe you forgot to add some new files?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2479 (comment)

wing328 · 2016-04-01T06:32:27Z

@kungfoo please take your time. Stable release v2.1.6 will be out soon so this change will go into the master after that.

wing328 · 2016-04-09T10:29:26Z

@kungfoo when you've time, would you please perform a rebase on the latest master?

kungfoo · 2016-04-09T17:24:16Z

Will do. I might get to do it tomorrow...
On 9 Apr 2016 12:29, "wing328" notifications@github.com wrote:

@kungfoo https://github.com/kungfoo when you've time, would you please
perform a rebase on the latest master?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2479 (comment)

kungfoo · 2016-04-26T12:57:41Z

Rebased unto master.

wing328 · 2016-04-26T13:11:29Z

modules/swagger-codegen/src/main/resources/Java/libraries/retrofit2/build.gradle.mustache

-    oltu_version = "1.0.1"
-    retrofit_version = "2.0.0-beta4"
-    gson_version = "2.6.2"
+    oltu_version = "1.0.0"


for oltu, shall we use 1.0.1 instead of 1.0.0?

Does not really matter to me. I can change it.

Yes please. We want to upgrade the dependencies to the latest version after stable releases.

Will do asap.

On Wed, Apr 27, 2016 at 8:14 AM, wing328 notifications@github.com wrote:

In
modules/swagger-codegen/src/main/resources/Java/libraries/retrofit2/build.gradle.mustache
#2479 (comment)
:

@@ -94,9 +94,8 @@ if(hasProperty('target') && target == 'android') {
}

ext {

oltu_version = "1.0.1"

retrofit_version = "2.0.0-beta4"

gson_version = "2.6.2"

oltu_version = "1.0.0"

Yes please. We want to upgrade the dependencies to the latest version
after stable releases.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/swagger-api/swagger-codegen/pull/2479/files/f528ee62c911a26f860dbc1d7878ee87a0f4778b#r61208586

Please take your time :)

…e mustache

wing328 · 2016-04-28T03:45:07Z

@kungfoo thanks for the PR, which has been merged into master.

…e-retrofit Update retrofit2 and retrofit2rx to use retrofit 2.0.1

cbornet · 2016-06-08T12:49:03Z

All the tests have been deleted !!

wing328 · 2016-06-08T16:15:06Z

@cbornet you're right. That's my oversight. I'll add them back with a PR

cbornet · 2016-06-08T16:25:36Z

Please wait ! I'm doing a PR to add them and some modifs

wing328 · 2016-06-08T16:58:51Z

@cbornet Saw your PR and will merge it into master later.

wing328 · 2016-06-08T17:23:24Z

Ref: #3083

wing328 added the Client: Java label Mar 31, 2016

wing328 added this to the v2.2.0 milestone Mar 31, 2016

wing328 added the Enhancement: General label Mar 31, 2016

wing328 added Client: Retrofit and removed Client: Java labels Apr 1, 2016

kungfoo force-pushed the feature/update-mainline-retrofit branch from 3a321df to 9bf2d3d Compare April 1, 2016 09:11

kungfoo added 2 commits April 26, 2016 14:24

Update retrofit2 and retrofit2rx to use retrofit 2.0.1

a3701cd

Fix pom.mustache of retrofit2 client lib

4b3dad7

kungfoo force-pushed the feature/update-mainline-retrofit branch from 9bf2d3d to f528ee6 Compare April 26, 2016 12:30

wing328 reviewed Apr 26, 2016
View reviewed changes

kungfoo added 2 commits April 27, 2016 10:01

Update libraries to the newest stable version

21b39e2

Regenrate samples after updating the libraries in pom and build.gradl…

39c08b2

…e mustache

kungfoo force-pushed the feature/update-mainline-retrofit branch from f528ee6 to 39c08b2 Compare April 27, 2016 08:04

wing328 merged commit f1ba6f5 into swagger-api:master Apr 28, 2016

zhenjun115 pushed a commit to zhenjun115/swagger-codegen that referenced this pull request May 8, 2016

Merge pull request swagger-api#2479 from ergon/feature/update-mainlin…

335f52b

…e-retrofit Update retrofit2 and retrofit2rx to use retrofit 2.0.1

cbornet mentioned this pull request May 15, 2016

[Retrofit] Remove retrofit 1 client #2395

Open

Update retrofit2 and retrofit2rx to use retrofit 2.0.1 #2479

Update retrofit2 and retrofit2rx to use retrofit 2.0.1 #2479

Uh oh!

Conversation

kungfoo commented Mar 31, 2016

Uh oh!

kungfoo commented Mar 31, 2016

Uh oh!

wing328 commented Apr 1, 2016

Uh oh!

kungfoo commented Apr 1, 2016

Uh oh!

wing328 commented Apr 1, 2016

Uh oh!

wing328 commented Apr 9, 2016

Uh oh!

kungfoo commented Apr 9, 2016

Uh oh!

kungfoo commented Apr 26, 2016

Uh oh!

wing328 Apr 26, 2016

Choose a reason for hiding this comment

Uh oh!

kungfoo Apr 26, 2016

Choose a reason for hiding this comment

Uh oh!

wing328 Apr 27, 2016

Choose a reason for hiding this comment

Uh oh!

kungfoo Apr 27, 2016

Choose a reason for hiding this comment

Uh oh!

wing328 Apr 27, 2016

Choose a reason for hiding this comment

Uh oh!

wing328 commented Apr 28, 2016

Uh oh!

cbornet commented Jun 8, 2016

Uh oh!

wing328 commented Jun 8, 2016

Uh oh!

cbornet commented Jun 8, 2016

Uh oh!

wing328 commented Jun 8, 2016

Uh oh!

wing328 commented Jun 8, 2016

Uh oh!

Uh oh!