Fix #6260 on master by preventing parallelism #10329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
…ism. This naive approach should be replaced in the future and allow parallel runs to achieve faster build times but this change will at least allow users to run maven with threads and other plugins and modules will run in parallel. This approach is also suggested by Apache Maven as a workaround: https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
Contributor
Author
Contributor
|
Thanks! I agree with your comments above, a better handling is in roadmap |
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fix #6260 - make plugin thread safe by preventing parallelism.
This naive approach should be replaced in the future and allow parallel runs to achieve faster build times but this change will at least allow users to run maven with threads and other plugins and modules will run in parallel.
I have used the generated SNAPSHOT plugin locally on my project and it fixed the issue. I also ran the
./bin/java-petstore-all.shand it passed.This approach is also suggested by Apache Maven as a workaround: https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3