Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpprest] number type with unspecified format build fails #7906

Closed
murzic4 opened this issue Mar 26, 2018 · 4 comments
Closed

[cpprest] number type with unspecified format build fails #7906

murzic4 opened this issue Mar 26, 2018 · 4 comments

Comments

@murzic4
Copy link
Contributor

murzic4 commented Mar 26, 2018

Description

Hi
Few days ago I faced issue that swagger-codegen doesn't correctly generate cpprest code for type "number" with no format specified and type "string" format "uuid".
today I have checked with the last release (swagger-codegen-cli-2.3.1.jar) and it looks like that issue with uuid is solved, but the problem with "number" is still exist

Swagger-codegen version

2.3.1

Swagger declaration file content or url

yaml file attached to the ticket (echo.yaml.log) , the issue with the code generated for the following description:

 - name: some_number
          in: query
          type: number
          required: true
Command line used for generation

java -jar swagger-codegen-cli.jar generate -l cpprest -o ./out -i ./echo.yaml

Steps to reproduce

to execute command above for the yaml file echo.yaml.log

Related issues/PRs

0001-cpprest-add-parameterToString-for-number-type-with-u.patch.log
echo.yaml.log

Suggest a fix/enhancement

please find possible patch here 0001-cpprest-add-parameterToString-for-number-type-with-u.patch.log

@etherealjoy
Copy link
Contributor

@murzic4
Do you wish to submit a PR for your patch?

@murzic4
Copy link
Contributor Author

murzic4 commented Mar 27, 2018

@etherealjoy
Sorry I have not enough experience in it. Could you please send me instruction how to do it?

@etherealjoy
Copy link
Contributor

etherealjoy commented Mar 27, 2018

@murzic4
Ok, you need to fork this project first then make your changes
Follow the guide here
https://gist.github.com/MarcDiethelm/7303312
https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md

Also thanks for suggesting the patch.

murzic4 added a commit to murzic4/swagger-codegen that referenced this issue Mar 28, 2018
@murzic4
Copy link
Contributor Author

murzic4 commented Mar 28, 2018

@etherealjoy
well.. i definitely have made something but not sure all steps were correct

murzic4 added a commit to murzic4/swagger-codegen that referenced this issue Mar 29, 2018
@wing328 wing328 closed this as completed in bad1885 Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants