[typescript-angular2] Bug: Request Content-Type other than json not allowed

[macjohnny]

Description

The changes in #6454 introduced setting the request content-type from the consumes property.

if (consumes != null && consumes.length > 0) {
    headers.set('Content-Type', consumes.filter(item => this.isJsonMime(item)).join(";"));
}

However, the content type is limited to json-like mime types. Therefore the content-type is set to an empty string if we e.g. upload a file and have

let consumes: string[] = [
     'multipart/form-data'
];

and since multipart/form-data is not a json mime-type, this results in setting and empty string value.
This in turn, results in an invalid content-type header being set, as explained e.g. here: angular/angular#11819

Content-Length: 315
Content-Type: , multipart/form-data; boundary=----WebKitFormBoundarys7BwSTvRA7Nf3WwQ
Host: petstore.swagger.io

This breaks e.g. the PetStore.uploadFile() API in the petStore example:

swagger-codegen/samples/client/petstore/typescript-angular-v4/npm/api/pet.service.ts

Line 204 in bd5b586

public uploadFile(petId: number, additionalMetadata?: string, file?: Blob, extraHttpRequestParams?: any): Observable<ApiResponse> {

Swagger-codegen version

2.3.0

Swagger declaration file content or url

See the petstore example

swagger-codegen/samples/client/petstore/typescript-angular-v4/npm/api/pet.service.ts

Line 633 in bd5b586

headers.set('Content-Type', consumes.filter(item => this.isJsonMime(item)).join(";"));

Command line used for generation

Steps to reproduce

Related issues/PRs

Maybe this is resolved with #6080

Suggest a fix/enhancement

Do not restrict the conten-type to json mime types.
Let angular detect the content-type automatically from the data.

[macjohnny]

@stoetti @keradus @sebastianhaas could you have a look at this issue?
what do you think about letting angular determine the content-type and simply remove the following code:

if (consumes != null && consumes.length > 0) {
    headers.set('Content-Type', consumes.filter(item => this.isJsonMime(item)).join(";"));
}

[macjohnny]

cc @wing328

[wing328]

However, the content type is limited to json-like mime types. Therefore the content-type is set to an empty string if we e.g. upload a file and have

@macjohnny I think that's a bug that needs to be fix. It should not used only JSON-related MIME types.

The correct logic should be checking If JSON-related MIME is found in consumes (or produces), it should use that. Otherwise, just use the first one in the list if there's more than 1 defined.

[macjohnny]

@wing328 i will file a PR as soon as #6574 is merged

[macjohnny]

this issue would be resolved by merging #6295

[macjohnny]

this issue was resolved with #6295

[wing328]

@macjohnny are you going to file another PR to fix the following as originally reported in this issue?

if (consumes != null && consumes.length > 0) {
    headers.set('Content-Type', consumes.filter(item => this.isJsonMime(item)).join(";"));
}

I don't think isJsonMime is used at the moment:

grep -R isJsonMime modules/swagger-codegen/src/main/resources/typescript-angular/*
modules/swagger-codegen/src/main/resources/typescript-angular/api.service.mustache:    public isJsonMime(mime: string): boolean {

[macjohnny]

@wing328 the issue was resolved with the changes introduced in #6295. This is why in #6574 I removed the isJsonMime() method. See also the comment by @bedag-moo #6295 (comment)