Discussion - tabs vs spaces

[bherila]

re #5299

@wing328 this has been a big sticking point among JS developers I've worked with who are used to 2-space indents. The tabs were a compromise so they could keep their 2-spaces based on editor setting, while the rest of the world uses 4-space. I respect the official TS style guidelines, so not suggesting undoing #5299. But I am slightly disappointed because now I have to post-process swagger-codegen with a script to replace 4-space back to tabs.

Does it make sense to start a feature request for a setting to control tab size and/or spaces output? Would anyone besides me be supportive of it?

[ePaul]

My usual approach is to not edit generated code, so it doesn't really matter for me how it is indented.
And if I edit it, then I can easily reformat it the moment I start editing, and it will stay that way.

I guess this approach doesn't help you?

[wing328]

@bherila have you tried using the -t option with customized templates (tab instead of spaces)? You can checkout the commit before the merge to restore the TS jQuery templates with tabs.

[bherila]

I have not, will check that out- thanks for pointing it out 👍

Also, I have to edit the generated file anyway to insert my own function in place of the base url... so it's not a huge inconvenience. Just thought it was an interesting point of discussion :)