[PHP] Better code format

[wing328]

Description

When using PHP CodeSniffer, we found potential enhancemnets for auto-generated PHP code.

Swagger-codegen version

• Current master

Steps to reproduce

composer install
./vendor/bin/phpcs --extensions=php ./lib

Related issues

#5190 (comment)

Suggest a Fix

If anyone wants to work on the enhancement, please reply to let us know.

[dkarlovi]

This was actually being worked on in #3898, I never got around to resubmitting the changes. Would need to take into account changes from #5190, though.

[wing328]

@dkarlovi right. I remember your PRs.

#5190 is submitted against 2.3.0 so your work on the master version of PHP API client is still valid.

After merging #5190 into 2.3.0, I'll publish a report by PHP CodeSniffer so that everyone knows what needs to be enhanced.

[dkarlovi]

In #3863 I've added support for PHP CS Fixer which seems to becoming PHP CS style tool of choice, not only can it find CS violations, it can fix them.

Would need to update the config file for a new version. Also, I'm using full code inspection from PHPStorm which also catches typos and such (some of which are also fixed in the PR linked).

[wing328]

For the time being, we can leverage PHP-CS-Fixer to update the code in terms of style and format.

Ideally I want to update the templates for PHP API client without the need to run php-cs-fixer manually.

[dkarlovi]

That was the original idea, but you get to also run php-cs-fixer from CI, it can also be run in "find only" mode.