-
Notifications
You must be signed in to change notification settings - Fork 430
fix issue-3 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue-3 #4
Conversation
travis fails now - as far as I can see it's because the necessary version of guava (23) was updated in the swagger-codegen/pom.xml on the 17-01-2018, but travis seems to be using a snapshot of a few days earlier:
|
@ljgw the problem is that I have compared the last released version (
See issue #5 |
You can rebase your change on top of PR #6, but as I wrote there this only solves the first errors mentionned in your Travis Build:
|
now that #7 is fixed, rebasing on master should help your change |
Thanks, @jmini. travis-ci will still fail because it cannot find |
Some code was pushed on master for |
Some more code was pushed on master to fix the travis-ci build, and now it passes! I rebased on master and pushed. |
Changes in this branch ensure
hasMore
in all of them, except the last. (so, comma's in the correct locations in the generated code)