Skip to content

fix issue-3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2018
Merged

fix issue-3 #4

merged 1 commit into from
Feb 10, 2018

Conversation

ljgw
Copy link
Contributor

@ljgw ljgw commented Feb 4, 2018

Changes in this branch ensure

  1. Multiple produces list-items result in the hasMore in all of them, except the last. (so, comma's in the correct locations in the generated code)
  2. Only distinct media-types in produces

@ljgw
Copy link
Contributor Author

ljgw commented Feb 4, 2018

travis fails now - as far as I can see it's because the necessary version of guava (23) was updated in the swagger-codegen/pom.xml on the 17-01-2018, but travis seems to be using a snapshot of a few days earlier:

[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/io/swagger/swagger-codegen/3.0.0-SNAPSHOT/swagger-codegen-3.0.0-20180112.231844-20.pom

@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

@ljgw the problem is that guava no longer in the dependency tree is.

I have compared the last released version (1.0.0-rc0) and the current SNAPSHOT version.

Comparison of the dependency tree

guava version 23.0 was provided by swagger-codegen (version 3.0.0-rc0). With the current 3.0.0-SNAPSHOT version, this is no longer the case.

See issue #5

@jmini jmini mentioned this pull request Feb 6, 2018
@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

You can rebase your change on top of PR #6, but as I wrote there this only solves the first errors mentionned in your Travis Build:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project swagger-codegen-generators: Compilation failure: Compilation failure: 
[ERROR] /home/travis/build/swagger-api/swagger-codegen-generators/src/main/java/io/swagger/codegen/languages/java/AbstractJavaCodegen.java:[4,30] package com.google.common.base does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen-generators/src/main/java/io/swagger/codegen/languages/DefaultCodegenConfig.java:[4,30] package com.google.common.base does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen-generators/src/main/java/io/swagger/codegen/languages/DefaultCodegenConfig.java:[5,33] package com.google.common.collect does not exist
[ERROR] /home/travis/build/swagger-api/swagger-codegen-generators/src/main/java/io/swagger/codegen/languages/DefaultCodegenConfig.java:[63,24] cannot find symbol

@jmini
Copy link
Contributor

jmini commented Feb 7, 2018

now that #7 is fixed, rebasing on master should help your change

@ljgw
Copy link
Contributor Author

ljgw commented Feb 7, 2018

Thanks, @jmini. travis-ci will still fail because it cannot find ./mvnw, but at least everything compiles now on travis-ci.

@jmini
Copy link
Contributor

jmini commented Feb 8, 2018

Some code was pushed on master for mvnw(see #8)

@ljgw
Copy link
Contributor Author

ljgw commented Feb 8, 2018

Some more code was pushed on master to fix the travis-ci build, and now it passes! I rebased on master and pushed.

@HugoMario HugoMario merged commit 17034d1 into swagger-api:master Feb 10, 2018
@HugoMario
Copy link
Contributor

thanks @ljgw and @jmini i just merged the PR.

@ljgw ljgw deleted the issue-3 branch February 13, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants