Skip to content

Propagate default parameter value to CodegenParameter object #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwiehl wants to merge 4 commits into
base: master
Choose a base branch
from
+30 −0
Open

Propagate default parameter value to CodegenParameter object #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e62808
Propagate default parameter value to CodegenParameter object
mwiehl May 4, 2019
c602c1f
Merge branch 'master' into master
mwiehl Jun 15, 2019
5b150f4
Merge branch 'master' into master
mwiehl Nov 27, 2023
8df7347
Merge branch 'swagger-api:master' into master
mwiehl Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/io/swagger/codegen/v3/generators/DefaultCodegenConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2589,6 +2589,10 @@ public CodegenParameter fromParameter(Parameter parameter, Set<String> imports)
codegenParameter.getVendorExtensions().put(CodegenConstants.HAS_VALIDATION_EXT_NAME, Boolean.TRUE);
}

Object defaultValue = parameterSchema.getDefault();
if (defaultValue != null) {
codegenParameter.defaultValue = defaultValue.toString();
}
}

// Issue #2561 (neilotoole) : Set the is<TYPE>Param flags.
Expand Down
26 changes: 26 additions & 0 deletions src/test/java/io/swagger/codegen/v3/generators/DefaultCodegenConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,32 @@ public void testFromOperation_BodyParamsUnique() {
Assert.assertEquals(true, codegenOperation.bodyParams.get(0).getVendorExtensions().get("x-has-more"));
}

@Test
public void testFromParameter_DefaultValue() {
PathItem dummyPath = new PathItem()
.get(new Operation());
OpenAPI openAPI = new OpenAPI()
.path("dummy", dummyPath);

DefaultCodegenConfig codegen = new P_DefaultCodegenConfig();

Operation operation = new Operation();
Parameter param = new Parameter()
.in("query")
.name("testParameter");
operation.addParametersItem(param);

CodegenOperation codegenOperation = codegen.fromOperation("/path", "GET", operation, null, openAPI);
Assert.assertNull(codegenOperation.allParams.get(0).getDefaultValue());

Schema schema = new Schema();
schema.setDefault("myDefaultValue");
param.setSchema(schema);

codegenOperation = codegen.fromOperation("/path", "GET", operation, null, openAPI);
Assert.assertEquals(codegenOperation.allParams.get(0).getDefaultValue(), "myDefaultValue");
}

@Test(dataProvider = "testGetCollectionFormatProvider")
public void testGetCollectionFormat(Parameter.StyleEnum style, Boolean explode, String expectedCollectionFormat) {
final DefaultCodegenConfig codegen = new P_DefaultCodegenConfig();
Expand Down