added instagram logo #386
Merged
added instagram logo #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasDeBruijn
approved these changes
Sep 23, 2024
SilasPeters
reviewed
Sep 23, 2024
Member
SilasPeters
left a comment
SilasPeters
left a comment
There was a problem hiding this comment.
I approve the code changes, but doorgeefluik would be better. I suggest we include the link in this PR, tomorrow
Member
Author
|
A board member currently has the URL's on his to-do; if all goes well I should get a follow-up as soon as they exist; i suggest we keep this PR open untill then |
SamStaijen
deleted the
381-link-to-instagram-at-the-bottom-of-the-website
branch
stickyPiston
pushed a commit
that referenced
this pull request
Oct 9, 2024
* added instagram logo * added doorgeefluik url's
stickyPiston
pushed a commit
that referenced
this pull request
Oct 9, 2024
* added instagram logo * added doorgeefluik url's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the instagram logo to the footer. Ideally I would pass all the external url's through 'doorgeefluik' (reduces possible search work would there be a url change on an external domain), but I beleave putting data in the 'doorgeefluik' database can be done as IT Crowd only, as there has not been a single commit on an active branch in 'doorgeefluik' the past 2 years. For now it is a instagram.com url, which is fine i guess