Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure.ac #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

traveller42
Copy link

Changed configure.ac to use subdir-objects

Changed configure.ac to use subdir-objects
@traveller42
Copy link
Author

This suppresses many warnings in my environment.

Pulled latest version of each m4 macro file related to Boost from GNU
repostitory (git.savanna.gnu.org).
@traveller42
Copy link
Author

Updating the m4 macros to the latest versions resulted in a clean run through configure on my Ubuntu 15.04 system.

Added m4 macro to handle pthread detection
Updated configure.ac to launch pthread detection
Updated fuegomain/Makefile.am to use the values detected for pthreads
@traveller42
Copy link
Author

I think this completes the changes needed for the autotools to properly handle the multiarch Boost libraries and related pthreads support.

For the pthreads, I used the approach suggested in this message from the autoconf archive maintainers list.

This works correctly on my Ubuntu 15.04 system with no additional steps and no errors.
./setup_build.sh
cd build/opt
make

The specific changes should use whatever flags are created by the AX_PTHREAD macro. This should cover several build environments.

@mmueller65
Copy link

Thanks for Fuego patches. I have some questions.

  • I updated to the most recent m4 macros, very similar to your 2nd patch. See -r 2022.
  • Regarding adding subdir-objects, is it a matter of your personal preference, or does it break your build to not have it? Which system is this on? Note that our recommended way is to use separate build directories for each type of build, such as opt or dbg. See the setup-build.sh script to help with that.
  • Regarding pthread, I believe this is already handled correctly by the current ax_boost_thread.m4 version. For your build, do you need both ax_pthread.m4 and ax_boost_thread.m4 ?

Martin

@traveller42
Copy link
Author

I was reading commentary online looking for general responses to the errors I was seeing. The system was running Ubuntu 15.04 at the time. I'm now on 15.10 for that system and planning to upgrade to 16.04 soon. I have a 16.04 environment I can use, so I can look at that first.

The main system (currently on 15.10) has an AMD FX-8120 and 16 GB RAM. The other system is an old laptop with an Intel Core 2 Duo and 4 GB RAM. Both are running on 64-bit versions of Ubuntu.

With respect to opt and dbg, my goal was a clean build of the engine for testing. Once I had a clean build, I had what I needed for my project.

I'll need to check the current tip to see what I still need. After the other changes, I may not need anything.

@foosly
Copy link

foosly commented Dec 14, 2018

hi,
current ax_boost_thread.m4 breaks my build with gcc 8.2.1 on linux because LD_FLAGS does not integrate "-pthread". Upgrading to m4 macros used in https://github.com/facebook/redex works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants