Add endpoints to erase payload and response #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-andor
force-pushed
the
andor/expunge-message-content-and-response
branch
3 times, most recently
from
ee505a4
to
85a7ae7
Compare
tasn
reviewed
Jan 27, 2023
svix-andor
force-pushed
the
andor/expunge-message-content-and-response
branch
from
85a7ae7
to
5e080cc
Compare
tasn
reviewed
Jan 27, 2023
svix-andor
force-pushed
the
andor/expunge-message-content-and-response
branch
from
5e080cc
to
5b82c52
Compare
svix-andor
force-pushed
the
andor/expunge-message-content-and-response
branch
from
5b82c52
to
9eedb41
Compare
svix-gabriel
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These endpoints can be used to erase the payload of a message, and the response body of attempts. They can be useful in cases where a message was inadvertently sent with sensitive data that it shouldn't have contained, or an endpoint returned a response body with something of the same sort.
Erasing message payloads is technically OK, the worker already handles the case where there's no payload (due to payload expiration) and the response body is not currently used by svix, it is only retained for troubleshooting purposes.