Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PATCH endpoints for relevant models #599

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Implement PATCH endpoints for relevant models #599

merged 6 commits into from
Aug 1, 2022

Conversation

svix-daniel
Copy link
Contributor

@svix-daniel svix-daniel commented Jul 29, 2022 •
edited
Loading

This PR implements PATCH endpoints for all models in which updating via PUT is
supported -- applications,event_types, and endpoints.

@svix-daniel svix-daniel marked this pull request as ready for review August 1, 2022 13:38
tasn
tasn approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably reduce a lot of this duplication, but I'm not currently sure how (short of a proc macro)...

@svix-daniel svix-daniel merged commit 9fbbfc4 into main Aug 1, 2022
@svix-daniel svix-daniel deleted the daniel/patch-endpoints branch August 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasn tasn tasn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-daniel @tasn