Consolidate configuration validation to the cfg module #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-daniel
changed the title
svix-daniel
force-pushed
the
daniel/configuration-validation
branch
from
9c7de57
to
1461f18
Compare
svix-daniel
changed the title
tasn
reviewed
Jul 27, 2022
svix-daniel
force-pushed
the
daniel/configuration-validation
branch
from
1461f18
to
1b57df0
Compare
tasn
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes miscellaneous improvements to the
ConfigurationInnervalidation to provide clearer error messages and avoid validation code scattered elsewhere in the codebase.The main change is to the Redis DSN validation and the associated helper methods for fetching the key value store backend used by both the queue and the cache.
This also changes the type of the
listen_addressfrom aStringto aSocketAddrsuch as to avoid parsing it elsewhere in the code.