Add optional cache prefix parameter to kv_def #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
reviewed
Jul 19, 2022
svix-daniel
force-pushed
the
daniel/kv-prefix
branch
from
f178b6b
to
6f2170f
Compare
tasn
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
kv_defmacro was there previously, we did not use it in some placesbecause of the need for custom prefixes. This PR augments the
kv_defandstring_kv_defmacros to take an optional string literal to be used as thePREFIX_CACHEconstant for theCacheKeytrait.Additionally this replaces the two manual implementations of the cache traits
with this new macro syntax.