Remove unwraps from non-test code in queue/redis #551
Conversation
|
Would love feedback on this. I've only done a cursory run through. Open questions include, in functions that call and catch errors from the |
| @@ -367,15 +370,17 @@ fn to_redis_key(delivery: &TaskQueueDelivery) -> String { | |||
| format!( | |||
There was a problem hiding this comment.
I wonder if we should just change this function to return a result, just in case, since this method is called w/in the send method which is potentially heavily used.
There was a problem hiding this comment.
I agree. I think this is much more concerning than e.g. the migrations.
| migrate_list(&mut conn, v1_main, v2_main).await; | ||
| migrate_list(&mut conn, v1_processing, v2_processing).await; | ||
| migrate_sset(&mut conn, v1_delayed, v2_delayed).await; | ||
| let r1 = migrate_list(&mut conn, v1_main, v2_main).await; |
There was a problem hiding this comment.
The way to do it in tests is just to unwrap. This is too cumbersome.
|
This was now fixed by @svix-james in another PR, no? |
|
Outdated in many ways. |
We had a lot of unwraps in our Redis-based queue implementation. This PR refactors them to be
.expect()s where appropriate, or to bubble errors up to a calling function that catches them.