Server CI: fix caching to actually work #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't setting the server subdirectory so the caching wasn't actually working. Fixes #329
tasn
force-pushed
the
tom/ci-cache
branch
2 times, most recently
from
43489a5
to
3e7a323
Compare
The idea was to do a quick check before doing the full check across different versions. The other idea was to only run clippy an rustfmt once. Though since we want clippy and rustfmt to run on both versions anyway (in case those changed), and that it's actually quick to do so, it made more sense to just run both on both without the multi-step.
svix-dylan
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting the server subdirectory so the caching wasn't
actually working.
This change also removed the multi-step checks in order to make the CI
even faster.
Fixes #329