Rust: Streamline deserialization/validation of endpoint secrets #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
reviewed
Apr 13, 2022
tasn
reviewed
Apr 13, 2022
Ensure that prefix matches before decoding secret; validate appropriate key length
jaymell
force-pushed
the
enable-endpoint-secret-test
branch
from
5a120ef
to
20a8990
Compare
jaymell
changed the title
tasn
approved these changes
Apr 13, 2022
|
I've re-tooled deserialization and validation per comments and other discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.