Tests: Recover failed webhooks #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
recover-failed-webhooks
branch
3 times, most recently
from
7bbb6aa
to
6bc0d30
Compare
jaymell
force-pushed
the
recover-failed-webhooks
branch
from
6bc0d30
to
e12b51a
Compare
|
Let's have Daniel take a look, but please fix the title. You are not working on recover failed webhooks, but rather adding tests for it. |
svix-daniel
reviewed
Apr 5, 2022
|
Also non-essential, but I usually like to leave assertions and unwraps in the function marked as |
jaymell
force-pushed
the
recover-failed-webhooks
branch
from
e12b51a
to
87b389c
Compare
Add tests to ensure that failed webhooks are retried with expected count based on `since` time specified, and ensure recover requests are rejected if `since` time exceeds age limit
jaymell
force-pushed
the
recover-failed-webhooks
branch
from
87b389c
to
6df7f80
Compare
|
I refactored based on comments and removed the |
svix-daniel
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to ensure proper functioning of recover-failed-webhooks endpoint. This will validate that particular failed messages are retried an expected number of times based upon message creation time and the
sincetime passed to the endpoint.