Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libs(ruby): expose patch endpoints #1264

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

maful
Copy link
Contributor

@maful maful commented Mar 10, 2024

Motivation

I've noticed that the patch endpoints, which were introduced back in v1.6.0, aren't currently exposed in the way they should be. This omission can lead to errors when users attempt to utilize these patch endpoints, particularly when building request bodies for endpoint resources. A case in point is the Svix::EndpointPatch error, which serves as an illustrative example of the underlying issue:

irb(main):001:0> Svix::EndpointPatch.new({})
(irb):1:in `<main>': uninitialized constant Svix::EndpointPatch (NameError)

Svix::EndpointPatch.new({})
    ^^^^^^^^^^^^^^^
Did you mean?  Svix::EndpointUpdate
               Svix::EndpointOut
               Svix::EndpointAPI

Solution

To address this issue, I propose to expose the patch endpoints within the ruby/lib/svix.rb file.

@maful maful requested a review from a team as a code owner March 10, 2024 05:59
Copy link
Contributor

@svix-james svix-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@svix-onelson svix-onelson merged commit 6c99a0c into svix:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants