[javascript] Remove fetch polyfill #1162
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
svix-fetch
uses Node specific APIs which causes issues when using non-node environments, like Cloudflare Workers, and was imported as a side effect which means that bundlers cannot tree shakesvix
.fetch
is now supported on all maintained Nodejs versions. Also as a general rule users should be responsible for polyfilling fetch, not libraries.Solution
Use
fetch
from globalThis and mark the library as side effect free.