Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libs(Go): extra nil check for options in EventType.DeleteWithOptions #1082

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Libs(Go): extra nil check for options in EventType.DeleteWithOptions #1082

merged 1 commit into from
Sep 26, 2023

Conversation

svix-onelson
Copy link
Contributor

Motivation

I forgot I was writing Go and neglected to check for nil when optionally setting options.

Solution

Keep checking for nil all the way down.

@svix-onelson svix-onelson requested a review from a team September 25, 2023 23:51
@svix-onelson svix-onelson merged commit 7bc1d38 into main Sep 26, 2023
1 check passed
@svix-onelson svix-onelson deleted the onelson/go-whoopsie branch September 26, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasn tasn tasn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-onelson @tasn