Avoid serde_derive blob and ban affected versions via cargo-deny #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-daniel
force-pushed
the
daniel/serde-blob
branch
2 times, most recently
from
8f12f56
to
4a754ad
Compare
svix-daniel
force-pushed
the
daniel/serde-blob
branch
from
4a754ad
to
bc4af72
Compare
tasn
reviewed
Aug 22, 2023
svix-daniel
force-pushed
the
daniel/serde-blob
branch
from
bc4af72
to
2185905
Compare
svix-james
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1042 by updating the version of
serdespecified in the server'sCargo.tomlto ensureserde_derive's version is not affected by the binary blob.Similarly ensures that all versions of the crate with the blob are banned via
cargo-deny.