Skip to content

Commit

Permalink
Csharp: make options optional for all list endpoinst.
Browse files Browse the repository at this point in the history 
This is following the discussion in:
https://github.com/svix/svix-webhooks/pull/248\#issuecomment-1137223221
  • Loading branch information
@tasn
tasn committed May 25, 2022
1 parent 7df7306 commit f27c84b
Show file tree
Hide file tree
Showing 13 changed files with 62 additions and 62 deletions.
10 changes: 5 additions & 5 deletions csharp/Svix/Abstractions/IApplication.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ namespace Svix.Abstractions
{
public interface IApplication
{
public ApplicationOut Create(ApplicationIn application, ApplicationCreateOptions options,
public ApplicationOut Create(ApplicationIn application, ApplicationCreateOptions options = null,
string idempotencyKey = default);

public Task<ApplicationOut> CreateAsync(ApplicationIn application, ApplicationCreateOptions options,
public Task<ApplicationOut> CreateAsync(ApplicationIn application, ApplicationCreateOptions options = null,
string idempotencyKey = default, CancellationToken cancellationToken = default);

bool Delete(string appId, string idempotencyKey = default);
Expand All @@ -24,13 +24,13 @@ Task<bool> DeleteAsync(string appId, string idempotencyKey = default,
Task<ApplicationOut> GetAsync(string appId, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<ApplicationOut> List(ListOptions options, string idempotencyKey = default);
List<ApplicationOut> List(ListOptions options = null, string idempotencyKey = default);

Task<List<ApplicationOut>> ListAsync(ListOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default);
Task<List<ApplicationOut>> ListAsync(ListOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default);

ApplicationOut Update(string appId, ApplicationIn application, string idempotencyKey = default);

Task<ApplicationOut> UpdateAsync(string appId, ApplicationIn application, string idempotencyKey = default,
CancellationToken cancellationToken = default);
}
}
}
4 changes: 2 additions & 2 deletions csharp/Svix/Abstractions/IEndpoint.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ Task<EndpointHeadersOut> GetHeadersAsync(string appId, string endpointId, string
Task<string> GetSecretAsync(string appId, string endpointId, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<EndpointOut> List(string appId, ListOptions options, string idempotencyKey = default);
List<EndpointOut> List(string appId, ListOptions options = null, string idempotencyKey = default);

Task<List<EndpointOut>> ListAsync(string appId, ListOptions options, string idempotencyKey = default,
Task<List<EndpointOut>> ListAsync(string appId, ListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

bool PatchHeaders(string appId, string endpointId, EndpointHeadersPatchIn headers, string idempotencyKey = default);
Expand Down
6 changes: 3 additions & 3 deletions csharp/Svix/Abstractions/IEventType.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ Task<EventTypeOut> CreateAsync(EventTypeIn eventType, string idempotencyKey = de
Task<EventTypeOut> GetAsync(string eventType, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<EventTypeOut> List(EventTypeListOptions options, string idempotencyKey = default);
List<EventTypeOut> List(EventTypeListOptions options = null, string idempotencyKey = default);

Task<List<EventTypeOut>> ListAsync(EventTypeListOptions options, string idempotencyKey = default,
Task<List<EventTypeOut>> ListAsync(EventTypeListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

EventTypeOut Update(string eventType, EventTypeUpdate update, string idempotencyKey = default);

Task<EventTypeOut> UpdateAsync(string eventType, EventTypeUpdate update, string idempotencyKey = default,
CancellationToken cancellationToken = default);
}
}
}
6 changes: 3 additions & 3 deletions csharp/Svix/Abstractions/IIntegration.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ Task<bool> DeleteAsync(string appId, string integrationId, string idempotencyKey
Task<string> GetKeyAsync(string appId, string integrationId, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<IntegrationOut> List(string appId, ListOptions options, string idempotencyKey = default);
List<IntegrationOut> List(string appId, ListOptions options = null, string idempotencyKey = default);

Task<List<IntegrationOut>> ListAsync(string appId, ListOptions options, string idempotencyKey = default,
Task<List<IntegrationOut>> ListAsync(string appId, ListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

string RotateKey(string appId, string integrationId, string idempotencyKey = default);
Expand All @@ -41,4 +41,4 @@ Task<string> RotateKeyAsync(string appId, string integrationId, string idempoten

Task<IntegrationOut> UpdateAsync(string appId, string integrationId, IntegrationUpdate integration, string idempotencyKey = default, CancellationToken cancellationToken = default);
}
}
}
10 changes: 5 additions & 5 deletions csharp/Svix/Abstractions/IMessage.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,20 @@ namespace Svix.Abstractions
{
public interface IMessage
{
MessageOut Create(string appId, MessageIn message, MessageCreateOptions options,
MessageOut Create(string appId, MessageIn message, MessageCreateOptions options = null,
string idempotencyKey = default);

Task<MessageOut> CreateAsync(string appId, MessageIn message, MessageCreateOptions options,
Task<MessageOut> CreateAsync(string appId, MessageIn message, MessageCreateOptions options = null,
string idempotencyKey = default, CancellationToken cancellationToken = default);

MessageOut Get(string appId, string messageId, string idempotencyKey = default);

Task<MessageOut> GetAsync(string appId, string messageId, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<MessageOut> List(string appId, MessageListOptions options, string idempotencyKey = default);
List<MessageOut> List(string appId, MessageListOptions options = null, string idempotencyKey = default);

Task<List<MessageOut>> ListAsync(string appId, MessageListOptions options, string idempotencyKey = default,
Task<List<MessageOut>> ListAsync(string appId, MessageListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);
}
}
}
26 changes: 13 additions & 13 deletions csharp/Svix/Abstractions/IMessageAttempt.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,44 +12,44 @@ public interface IMessageAttempt

Task<MessageAttemptOut> GetAttemptAsync(string appId, string attemptId, string messageId, string idempotencyKey = default, CancellationToken cancellationToken = default);

List<EndpointMessageOut> ListAttemptedMessages(string appId, string endpointId, MessageAttemptListOptions options,
List<EndpointMessageOut> ListAttemptedMessages(string appId, string endpointId, MessageAttemptListOptions options = null,
string idempotencyKey = default);

Task<List<EndpointMessageOut>> ListAttemptedMessagesAsync(string appId, string endpointId, MessageAttemptListOptions options,
Task<List<EndpointMessageOut>> ListAttemptedMessagesAsync(string appId, string endpointId, MessageAttemptListOptions options = null,
string idempotencyKey = default, CancellationToken cancellationToken = default);

List<MessageAttemptOut> ListAttemptsByEndpoint(string appId, string endpointId, AttemptsByEndpointListOptions options, string idempotencyKey = default);
List<MessageAttemptOut> ListAttemptsByEndpoint(string appId, string endpointId, AttemptsByEndpointListOptions options = null, string idempotencyKey = default);

Task<List<MessageAttemptOut>> ListAttemptsByEndpointAsync(string appId, string endpointId, AttemptsByEndpointListOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default);
Task<List<MessageAttemptOut>> ListAttemptsByEndpointAsync(string appId, string endpointId, AttemptsByEndpointListOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default);

List<MessageAttemptOut> ListAttemptsByMessage(string appId, string messageId, AttemptsByMessageListOptions options, string idempotencyKey = default);
List<MessageAttemptOut> ListAttemptsByMessage(string appId, string messageId, AttemptsByMessageListOptions options = null, string idempotencyKey = default);

Task<List<MessageAttemptOut>> ListAttemptsByMessageAsync(string appId, string messageId, AttemptsByMessageListOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default);
Task<List<MessageAttemptOut>> ListAttemptsByMessageAsync(string appId, string messageId, AttemptsByMessageListOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default);

List<MessageAttemptEndpointOut> ListAttemptsForEndpoint(string appId, string messageId, string endpointId,
AttemptsByEndpointListOptions options, string idempotencyKey = default);
AttemptsByEndpointListOptions options = null, string idempotencyKey = default);

Task<List<MessageAttemptEndpointOut>> ListAttemptsForEndpointAsync(string appId, string messageId, string endpointId,
AttemptsByEndpointListOptions options, string idempotencyKey = default,
AttemptsByEndpointListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<MessageAttemptOut> ListAttempts(string appId, string messageId,
MessageAttemptListOptions options, string idempotencyKey = default);
MessageAttemptListOptions options = null, string idempotencyKey = default);

Task<List<MessageAttemptOut>> ListAttemptsAsync(string appId, string messageId,
MessageAttemptListOptions options, string idempotencyKey = default,
MessageAttemptListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

List<MessageEndpointOut> ListAttemptedDestinations(string appId, string messageId,
ListOptions options, string idempotencyKey = default);
ListOptions options = null, string idempotencyKey = default);

Task<List<MessageEndpointOut>> ListAttemptedDestinationsAsync(string appId, string messageId,
ListOptions options, string idempotencyKey = default,
ListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default);

bool ResendWebhook(string appId, string messageId, string endpointId, string idempotencyKey = default);

Task<bool> ResendWebhookAsync(string appId, string messageId, string endpointId,
string idempotencyKey = default, CancellationToken cancellationToken = default);
}
}
}
8 changes: 4 additions & 4 deletions csharp/Svix/Application.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public Application(ISvixClient svixClient, IApplicationApi applicationApi)
_applicationApi = applicationApi ?? throw new ArgumentNullException(nameof(applicationApi));
}

public ApplicationOut Create(ApplicationIn application, ApplicationCreateOptions options, string idempotencyKey = default)
public ApplicationOut Create(ApplicationIn application, ApplicationCreateOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -46,7 +46,7 @@ public ApplicationOut Create(ApplicationIn application, ApplicationCreateOptions
}
}

public async Task<ApplicationOut> CreateAsync(ApplicationIn application, ApplicationCreateOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default)
public async Task<ApplicationOut> CreateAsync(ApplicationIn application, ApplicationCreateOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default)
{
try
{
Expand Down Expand Up @@ -178,7 +178,7 @@ public List<ApplicationOut> List(ListOptions options = null, string idempotencyK
}
}

public async Task<List<ApplicationOut>> ListAsync(ListOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default)
public async Task<List<ApplicationOut>> ListAsync(ListOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default)
{
try
{
Expand Down Expand Up @@ -246,4 +246,4 @@ public async Task<ApplicationOut> UpdateAsync(string appId, ApplicationIn applic
}
}
}
}
}
4 changes: 2 additions & 2 deletions csharp/Svix/Endpoint.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public async Task<string> GetSecretAsync(string appId, string endpointId, string
}
}

public List<EndpointOut> List(string appId, ListOptions options, string idempotencyKey = default)
public List<EndpointOut> List(string appId, ListOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -275,7 +275,7 @@ public List<EndpointOut> List(string appId, ListOptions options, string idempote
}
}

public async Task<List<EndpointOut>> ListAsync(string appId, ListOptions options, string idempotencyKey = default,
public async Task<List<EndpointOut>> ListAsync(string appId, ListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default)
{
try
Expand Down
6 changes: 3 additions & 3 deletions csharp/Svix/EventType.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public async Task<EventTypeOut> GetAsync(string eventType, string idempotencyKey
}
}

public List<EventTypeOut> List(EventTypeListOptions options, string idempotencyKey = default)
public List<EventTypeOut> List(EventTypeListOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -175,7 +175,7 @@ public List<EventTypeOut> List(EventTypeListOptions options, string idempotencyK
}
}

public async Task<List<EventTypeOut>> ListAsync(EventTypeListOptions options, string idempotencyKey = default,
public async Task<List<EventTypeOut>> ListAsync(EventTypeListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default)
{
try
Expand Down Expand Up @@ -247,4 +247,4 @@ public async Task<EventTypeOut> UpdateAsync(string eventType, EventTypeUpdate up
}
}
}
}
}
6 changes: 3 additions & 3 deletions csharp/Svix/Integration.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public async Task<string> GetKeyAsync(string appId, string integrationId, string
}
}

public List<IntegrationOut> List(string appId, ListOptions options, string idempotencyKey = default)
public List<IntegrationOut> List(string appId, ListOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -227,7 +227,7 @@ public List<IntegrationOut> List(string appId, ListOptions options, string idemp
}
}

public async Task<List<IntegrationOut>> ListAsync(string appId, ListOptions options, string idempotencyKey = default,
public async Task<List<IntegrationOut>> ListAsync(string appId, ListOptions options = null, string idempotencyKey = default,
CancellationToken cancellationToken = default)
{
try
Expand Down Expand Up @@ -345,4 +345,4 @@ public async Task<IntegrationOut> UpdateAsync(string appId, string integrationId
}
}
}
}
}
10 changes: 5 additions & 5 deletions csharp/Svix/Message.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public Message(ISvixClient svixClient, IMessageApi messageApi)
_messageApi = messageApi ?? throw new ArgumentException(nameof(messageApi));
}

public MessageOut Create(string appId, MessageIn message, MessageCreateOptions options, string idempotencyKey = default)
public MessageOut Create(string appId, MessageIn message, MessageCreateOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -47,7 +47,7 @@ public MessageOut Create(string appId, MessageIn message, MessageCreateOptions o
}
}

public async Task<MessageOut> CreateAsync(string appId, MessageIn message, MessageCreateOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default)
public async Task<MessageOut> CreateAsync(string appId, MessageIn message, MessageCreateOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default)
{
try
{
Expand Down Expand Up @@ -117,7 +117,7 @@ public async Task<MessageOut> GetAsync(string appId, string messageId, string id
}
}

public List<MessageOut> List(string appId, MessageListOptions options, string idempotencyKey = default)
public List<MessageOut> List(string appId, MessageListOptions options = null, string idempotencyKey = default)
{
try
{
Expand All @@ -144,7 +144,7 @@ public List<MessageOut> List(string appId, MessageListOptions options, string id
}
}

public async Task<List<MessageOut>> ListAsync(string appId, MessageListOptions options, string idempotencyKey = default, CancellationToken cancellationToken = default)
public async Task<List<MessageOut>> ListAsync(string appId, MessageListOptions options = null, string idempotencyKey = default, CancellationToken cancellationToken = default)
{
try
{
Expand Down Expand Up @@ -172,4 +172,4 @@ public async Task<List<MessageOut>> ListAsync(string appId, MessageListOptions o
}
}
}
}
}
Loading

0 comments on commit f27c84b

Please sign in to comment.