Skip to content

Commit

Permalink
bridge: Remove build step from CI workflow (#1347)
Browse files Browse the repository at this point in the history
There is no need to run `cargo build` separately from `cargo test` and
`cargo clippy`. The former command already builds the library with and
without `cfg(test)` (for unit tests and integration tests,
respectively).

Also rename some CI steps to make it more obvious what they're doing.
  • Loading branch information
svix-jplatte authored Jun 20, 2024
2 parents a8f2b8f + b91a3bc commit da3f408
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions .github/workflows/bridge-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ jobs:

- uses: taiki-e/install-action@nextest

- name: Install dependencies
- name: Clippy
run: cargo clippy --locked --all-targets --all-features -- -D warnings
working-directory: bridge

- name: Install system dependencies
# Packages should align with whatever is in the bridge/Dockerfile
run: |
sudo apt-get install -y \
Expand All @@ -74,22 +78,14 @@ jobs:
pkg-config=0.29.* \
zlib1g-dev=1:*
- name: Build
run: cargo build --locked
working-directory: bridge

- name: Start dependencies
- name: Start required services
run: docker compose -f "bridge/testing-docker-compose.yml" up -d

- name: Clippy
run: cargo clippy --all-targets --all-features -- -D warnings
working-directory: bridge

- name: Run tests
working-directory: bridge
run: ./run-tests.sh

- name: Stop dependencies
- name: Stop required services
run: docker compose -f "bridge/testing-docker-compose.yml" down

# deny-check:
Expand Down

0 comments on commit da3f408

Please sign in to comment.