Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect to relay after connection interruption #96

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

svix-andor
Copy link
Contributor

Transient network errors can cause the CLI to disconnect from the relay server. In this case we should try to reconnect with a gentle backoff. Fixes #95

Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried it and made sure it works with e.g. DNS connection reset by peer errors like the ticket?

relay/relay.go Show resolved Hide resolved
@svix-andor svix-andor merged commit 805793c into main Mar 23, 2023
@svix-andor svix-andor deleted the andor/reconnect-on-error branch March 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-reconnect to webhook relay
2 participants