Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable color by default if stdout is a TTY #9

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

svix-frank
Copy link
Contributor

Closes #7.

@svix-frank svix-frank requested a review from tasn June 2, 2021 19:41
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know golang, though I guess it's fine? Assuming this works on linux, macos and windows?
Is it possible to disable it? --no-color or something when it's on?

@svix-frank
Copy link
Contributor Author

svix-frank commented Jun 2, 2021

I don't know golang, though I guess it's fine? Assuming this works on linux, macos and windows?
Is it possible to disable it? --no-color or something when it's on?

Yeah it works on all platforms.
Currently you can pass --color=false to disable, although a --no-color flag sounds clearer.
Updated to reflect that suggestion.

@tasn
Copy link
Member

tasn commented Jun 2, 2021

--color=false actually sounds better! Maybe do that?

@svix-frank
Copy link
Contributor Author

--color=false actually sounds better! Maybe do that?

Okay, reverted!

@svix-frank svix-frank merged commit ae5618e into main Jun 2, 2021
@svix-frank svix-frank deleted the frank/color-tty-default branch June 2, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically enable --color if in a TTY
2 participants